8000 Esc closes fullscreen notes but keeps new note open · Issue #643 · blinkospace/blinko · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Esc closes fullscreen notes but keeps new note open #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mgschwan opened this issue Apr 16, 2025 · 3 comments
Open

Esc closes fullscreen notes but keeps new note open #643

mgschwan opened this issue Apr 16, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@mgschwan
Copy link

When editing Notes in the expanded view the note gets closed when pressing the Esc key. For example if the user wants to close a pulldown menu that popped up.
But it will leave the "new note" view open in expanded view making it not immediately obvious what happened.

The expected behavior when pressing Esc would be to close only a pulldown menu, not the whole note.

Maybe make the behavior configurable ( blocking esc altogether ) for a better editing experience.

At the least the view should go back to non-expanded to make it immediately clear that the current note has been closed.
@dosubot dosubot bot added the bug Something isn't working label Apr 16, 2025
@ssly
Copy link
Contributor
ssly commented Apr 16, 2025

Are you trying to say that when you are on the main interface, you opened a markdown note and pressing ESC can exit the note preview. However, when you open a markdown note and also click on the edit pop-up window, then click outside of it with your mouse, press ESC again - does this close the markdown note preview while keeping the edit window open?

@mgschwan
Copy link
Author

When I go to Notes and open a Note for editing then click on Toggle Fullscreen and then press Esc ( which happens quite a lot because of some pulldown menu popping that I want to go away ) then the current open note closes but I am still in fullscreen mode but now an empty note.

It seems like going into fullscreen also makes the empty note at the top of the Notes page fullscreen go fullscreen behind the current active note.

But honestly it would be better if Esc doesn't just close the note because the whole editing experience is very cumbersone in that case.
Alternatively have a popup asking if you want to exit fullscreen/close the note when the user presses Esc

@ssly
Copy link
Contributor
ssly commented Apr 21, 2025

When I go to Notes and open a Note for editing then click on Toggle Fullscreen and then press Esc ( which happens quite a lot because of some pulldown menu popping that I want to go away ) then the current open note closes but I am still in fullscreen mode but now an empty note.当我去笔记并打开一个笔记进行编辑，然后点击全屏切换，再按 Esc 键（因为有些下拉菜单弹出，我想让它消失，所以这种情况经常发生）时，当前打开的笔记会关闭，但我仍然处于全屏模式，但现在是一个空白的笔记。

It seems like going into fullscreen also makes the empty note at the top of the Notes page fullscreen go fullscreen behind the current active note.似乎进入全屏模式还会使笔记页面顶部空白的笔记也进入全屏，位于当前活动笔记的后面。

But honestly it would be better if Esc doesn't just close the note because the whole editing experience is very cumbersone in that case.但说实话，如果 Esc 键只是关闭笔记，那么整个编辑体验会非常繁琐。 Alternatively have a popup asking if you want to exit fullscreen/close the note when the user presses Esc或者，当用户按下 Esc 键时，弹出一个提示框询问是否要退出全屏/关闭笔记。

some pulldown menu popping？ such as？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgschwan @ssly
0