Add ability to share common / global env and secrets #7

jewilmeer · 2017-09-20T17:00:34Z

Some projects (especially the old ones), have a lot of envs & secrets configured. If you have a couple of deployments, you need to change them for all those deployments. Having a way of centralising those values would be very helpful.

Some ideas:

Give charts a env/secret template, which can be includes where needed
Use YAML inheritance like this: https://gist.github.com/bowsersenior/979804#file-stooges-yml
Some other creative solution (maybe helm already has a way of solving this?)

jewilmeer · 2017-09-20T17:07:23Z

Maybe globals work?
https://github.com/kubernetes/helm/blob/master/docs/charts.md#global-values

jewilmeer · 2017-09-20T17:15:14Z

This looks more promosing: https://github.com/kubernetes/helm/blob/master/docs/chart_template_guide/named_templates.md

JeanMertz · 2017-09-21T11:45:00Z

Just to give some context:

Charts are parsed as Golang text/template strings. On top of that, an extra superset of template functions is injected using the Sprig library.

In this case, named templates come from the standard Go library, so this can be used, without any requirements from Helm.

Having said that, the current implementation of Kubecrt considers charts.yml as one big YAML file, without any template parsing, and it instead sends along all the defined chart configs as-is to Helm. This works for template variables inside chart definitions, but not anywhere else.

This can be fixed though, so you make a good point, this should work as expected 👍

JeanMertz · 2017-09-21T22:25:39Z

I just tested this in a test chart:

{{- define "contacts" }}
      contacts:
      - jean@blendle.com
{{- end }}

apiVersion: v1
charts:
- blendle/web:
    version: ~> 0
    values:
      {{- template "contacts" }}

This works as expected when passed into kubecrt.

The problem, as you can see, is that you need to match the spacing in the define block, instead of in the template call.

Ideally, you'd want to do something like {{- template "contacts" | ident 6 }}, but that doesn't work:

template: test:9: unexpected "|" in template clause

Now, this is expected, because template takes an optional second argument (which is the scope within which the template's definition is executed). So the correct usage would be {{- template "contacts" . | indent 6 }}. But even when fixing that, it still doesn't work:

template: test:11:41: executing "test" at <6>: wrong type for value; expected string; got map[string]interface {}

This seems fixable, but I haven't found the cause yet.

JeanMertz mentioned this issue Sep 22, 2017

update epp dependency #10

Merged

JeanMertz closed this as completed in #10 Sep 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ability to share common / global env and secrets #7

Add ability to share common / global env and secrets #7

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add ability to share common / global env and secrets #7

Add ability to share common / global env and secrets #7

Comments

Uh oh!

Uh oh!

Uh oh!

Uh oh!