8000 Handling NaN and INF values in EdgeBuilder and Stroker · Issue #25 · blend2d/blend2d · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling NaN and INF values in EdgeBuilder and Stroker #25

Open
kobalicek opened this issue May 1, 2019 · 3 comments
Open

Handling NaN and INF values in EdgeBuilder and Stroker #25

kobalicek opened this issue May 1, 2019 · 3 comments
Labels
todo

Comments

@kobalicek
Copy link
Member
kobalicek commented May 1, 2019 •
edited
Loading

At the moment EdgeBuilder cannot handle NaN values properly in the following cases:

  • NaN is part of start/end point
  • NaN is part of a quadratic/cubic curve that is being flattened

The thing is that we do not handle NaNs at BLPath level, because of the following reasons:

  • Vertices can be transformed, so safe path values won't protect us from NaNs resulting from other computations
  • The plan is to allow users passing their own buffers that are not allocated by Blend2D nor part of BLPath, so Blend2D can never trust user input or BLPath content for security reasons

The problem is not how to handle NaNs, it's more about the behavior when NaN is encountered at this level. The following options are available:

  • Reset the whole EdgeBuffer content and return BL_ERROR_INVALID_GEOMETRY error
  • Treat NaN as some safe value like [0, 0] and render a corrupted image

I would prefer the first option as corrupted image is probably not what users would want anyway, but if anyone has different ideas then I'm interested.
@Wiladams
Copy link
Wiladams commented May 2, 2019

well, 'trust' is always a hard thing. I'd fail, and try to provide as much info as possible to find the error.

@Robert-M-Muench
Copy link

Option 1

@kobalicek kobalicek added the bug label Apr 18, 2020
@kobalicek
Copy link
Member Author

To update this: There is some work that has been already merged and should solve basic issues with NaNs, but this is not thoroughly tested. Keeping open, we need fuzzing to make sure this works as expected.

@kobalicek kobalicek added todo and removed bug labels Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wiladams @Robert-M-Muench @kobalicek
0