8000 CheckECRImageExists function return wrong result when too many tags exist in repository. · Issue #77 · bentoml/yatai-deployment · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CheckECRImageExists function return wrong result when too many tags exist in repository. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wellshs opened this issue Dec 22, 2022 · 0 comments
Open

CheckECRImageExists function return wrong result when too many tags exist in repository. #77

wellshs opened this issue Dec 22, 2022 · 0 comments
6D44

Comments

@wellshs
Copy link
wellshs commented Dec 22, 2022

I experienced that yatai-deployment try to build images which already exist in ecr repository.

aws-sdk-go's list images doesn't ensure list all the images from repository. It returns 100 as default.
I'm not sure how to support this case in yatai-deployment.
But, I think only checking only 100 results is too small for current usecase.(Share one repository for all bentos)
Currently, I'm trying to handle this issue with ECR repository lifecycle policy.

references

  1. yatai-deployment/services/image_builder.go

    Line 82 in cb5f5e2

    input := &ecr.ListImagesInput{
  2. https://docs.aws.amazon.com/sdk-for-go/api/service/ecr/#ListImagesInput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wellshs
0