8000 Leaking architecture: calling webhooks from GUI, mixing the logics of pagination vs. scheduler updates 😢 · Issue #133 · basf/metis-gui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Leaking architecture: calling webhooks from GUI, mixing the logics of pagination vs. scheduler updates 😢 #133
New issue
New issue
Closed
Closed
Leaking architecture: calling webhooks from GUI, mixing the logics of pagination vs. scheduler updates 😢#133
Labels
enhancementNew feature or request
@blokhin

Description

@blokhin
blokhin
opened on Mar 24, 2023

These are very bad things:

metis-gui/src/services/api.ts

Line 67 in 78a797d

postJSON(`/webhooks/calc_update${query}`, {})

https://github.com/basf/metis-bff/blob/6b86943a8d2c7310b82fcd9a332d44da503556ab/routes/%5Bversion%5D/webhooks/calc_update.js#L21

we have to refactor this at our earliest convenience...

FYI @pyoner @knopki

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0