Add auth.keys and deprecate auth.api_keys
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to load API keys from environemnt variables, the keys cannot appear in a map key. If an env var appears in a map key, Viper lowercases its value.
auth.keys to config and deprecate auth.api_keysauth.keys and deprecate auth.api_keys
Pull Request Test Coverage Report for Build 11127056523Details
💛 - Coveralls |
gertd
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to load API keys from environemnt variables, the keys cannot appear in a map key. If an env var appears in a map key, Viper lowercases its value. In addition, since there is no internal authorization, there's no point in requiring arbitrary identities that aren't ever going to be resolved anywhere.
This PR changes the structure to a list instead of a map.
With these changes, the config looks like this:
The existing
api_keysmap is still supported but a warning message is logged if it's used.