8000 Cloud / QCOW2: set basic image size to 16Gb for all cloud images by igorpecovnik · Pull Request #8046 · armbian/build · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cloud / QCOW2: set basic image size to 16Gb for all cloud images #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Cloud / QCOW2: set basic image size to 16Gb for all cloud images #8046

merged 1 commit into from
Apr 5, 2025

Conversation

igorpecovnik
Copy link
Member
@igorpecovnik igorpecovnik commented Apr 1, 2025 •
edited
Loading

Description

Cloud QCOW2 images are as small as they can be, but file-system could should be larger for start

This adds fixed +16Gb of resize, which doesn't make image any bigger, but when importing this as is, it might be better to not start without any free space. Now its 16Gb - cca. 600Mb.

How Has This Been Tested?

  • Generated and booted image

Checklist:

  • My changes generate no new warnings

@igorpecovnik
Cloud QCOW2 images are as small as they can be, but filesystem could …
d005952 
…/ should be larger for start

This adds fixed +16Gb of resize, which doesn't make image any bigger, but when importing this as is, it might be better to not start without any free space. Now its 16Gb - cca. 600Mb.
@github-actions github-actions bot added the size/small PR with less then 50 lines label Apr 1, 2025
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 1, 2025 •
edited
Loading

Walkthrough

The changes introduce a new global variable QCOW2_RESIZE_AMOUNT set to the value "16G". This modification is made in the UEFI common configuration file within the cloud branch case, specifying the designated size for resizing QCOW2 images. The update adds the variable declaration without altering any existing code or the overall structure of the case statement.

Suggested reviewers

  • rpardini
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3612c5b and d005952.

📒 Files selected for processing (1)
  • config/sources/families/include/uefi_common.inc (1 hunks)
🔇 Additional comments (1)
config/sources/families/include/uefi_common.inc (1)

29-29:

✅ Verification successful

Setting QCOW2 cloud image size to 16GB looks good.

This addition correctly implements the PR objective of increasing the basic size of cloud QCOW2 images to 16GB, which will provide users with more free space upon import.

I notice that line 68 uses a "+50G" format (with a plus sign) for a similar variable in the QEMU uboot section, while this implementation uses "16G" (without a plus). This difference in format might be intentional:

  • "+50G" likely means "increase by 50GB from the current size"
  • "16G" likely means "set to exactly 16GB"

If this interpretation is correct, then the implementation aligns with the PR objective.

🏁 Script executed:

#!/bin/bash
# Search for other usages of QCOW2_RESIZE_AMOUNT to verify expected format
rg "QCOW2_RESIZE_AMOUNT" --type=bash -C 3

Length of output: 70

🏁 Script executed:

#!/bin/bash
# Re-run the search for usages of QCOW2_RESIZE_AMOUNT without specifying file type
rg "QCOW2_RESIZE_AMOUNT" -C 3

Length of output: 65566

QCOW2 Image Size Setting Verified – No Further Changes Required

After re-running the search across the repository, the only occurrence of QCOW2_RESIZE_AMOUNT is the one in the file config/sources/families/include/uefi_common.inc where it is set to "16G". This aligns with the PR’s objective of establishing an absolute size (16 GB) for cloud QCOW2 images—providing more free space upon import. The noted format difference compared to the "+50G" setting in the QEMU U-Boot section is consistent with their respective semantics (absolute vs. relative).

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Apr 1, 2025
@leggewie
Copy link
Collaborator
leggewie commented Apr 1, 2025

do I understand it right that the 16GB will be dynamically allocated. the qcow file will still be more or less the same size and only grow as the file-system inside the VM is actually filling up?

@igorpecovnik
Copy link
Member Author

yes, file size is unchanged.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release labels Apr 5, 2025
@igorpecovnik igorpecovnik merged commit fc86a15 into main Apr 5, 2025
1 check passed
@igorpecovnik igorpecovnik deleted the setsize branch April 5, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @leggewie
0