[SR-10011] [Lexer] Raw Strings escape character sequence resembling multiline delimiter #34414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwu
reviewed
Oct 24, 2020
xwu
reviewed
Oct 24, 2020
Co-authored-by: Xiaodi Wu <13952+xwu@users.noreply.github.com>
|
@swift-ci Please smoke test |
|
Error from the CI: This doesn't seem to be related to my PR. On my machine, the compiler builds and passes all tests using ninja. Did a recent merge break the compiler? Or, is this from my PR? |
|
A recent merge; should be reverted now. Let's try again: @swift-ci Please smoke test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
This was referenced Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Lexer currently treats triple-quotes as a multiline delimiter for Strings. This PR allows the multiline delimiter (
""") to be escaped in raw Strings when a valid closing custom delimiter (e.g.#) is found before a newline.Problem
The Lexer does not register some strings that are technically valid according to the documented regex on string literals.
For example:
#"""#Gives the errors:
Multi-line string literal content must begin on a new line & Unterminated string literalImpact
This change does not impact any Strings that are already valid, rather, this PR enables a new set of String literals to be considered valid.
After merging this PR:
#"""#is now equivalent to"\""#"""text"#equates to"\"\"text"#"""is still the beginning of a multiline raw string.Links
Resolves SR-10011.
Replaces my previous PR attempt: #23115
Tagging @rintaro and @xwu from activity in my previous PR #23115.