8000 Updating site logo requires page refresh · Issue #2827 · apinf/platform · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updating site logo requires page refresh #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bajiat opened this issue Aug 18, 2017 · 3 comments
Closed

Updating site logo requires page refresh #2827

bajiat opened this issue Aug 18, 2017 · 3 comments
Labels
enhancement Platform Branding

Comments

@bajiat
Copy link
Contributor
bajiat commented Aug 18, 2017

Description

Logo and image handling are confusing to users. When an image is uploaded for example as platform logo, there is a delay in updating and images first appear as broken images.

Quote from a user:

If I remove the nonexisting logo and try to upload new one, nothing happens after file selection process is done
Now it appeared but as broken image.

Steps to reproduce

  1. Log into nightly as admin
  2. Go to settings menu by pressing the small icon next to your username
  3. Select Branding
  4. Delete the current logo for the site by pressing the trash can icon
  5. Select OK to confirm the delete
  6. Press upload logo
  7. Select the image to upload

Expected result

Logo is immediately updated to Branding settings and to the upper left corner of the site
@bajiat bajiat added the ready label Aug 18, 2017
@bajiat bajiat assigned brylie and unassigned saransh-dev Aug 21, 2017
@brylie
Copy link
Contributor
brylie commented Sep 26, 2017 •
edited
Loading

The steps to reproduce work correctly for me:

peek 2017-09-26 11-47

There may be a bit of unavoidable delay from when the image seems to be uploaded, to when it is actually sent to the server and published back to the client.

@brylie brylie added in progress and removed ready labels Sep 26, 2017
@brylie
Copy link
Contributor
brylie commented Sep 27, 2017

I recommend we put this issue in icebox for the following reasons:

  • the functionality works, although there are latency issues under some circumstances
    • it is not clear how often network latency will be high enough to cause significant confusion
  • the situation is not common (i.e. it does not seem like Platform Branding Logo will be changed often)

I agree that the missing image placeholder is not ideal. I am just recommending that we icebox this issue among other priorities.

@preriasusi
Copy link
Contributor

#3246 fixed this one.

@ghost ghost removed the in progress label Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Platform Branding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brylie @preriasusi @bajiat @saransh-dev
0