[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search and list dags by task id/name #37106

Open
2 tasks done
cnkumar20 opened this issue Jan 30, 2024 · 3 comments
Open
2 tasks done

search and list dags by task id/name #37106

cnkumar20 opened this issue Jan 30, 2024 · 3 comments
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests

Comments

@cnkumar20
Copy link
cnkumar20 commented Jan 30, 2024 •
edited
Loading

Description

currently we can search and list dags by dags name in the search box :

image

The same search box take task name/id and list all the dags containing that task . Might be good idea to support pattern matching

image

Use case/motivation

If instance has 100/1000's of dags helps search dags and commonality in tasks, tags assigned for a dag are more generic.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@cnkumar20 cnkumar20 added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Jan 30, 2024
@boring-cyborg boring-cyborg
Copy link
boring-cyborg bot commented Jan 30, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@RNHTTR RNHTTR added good first issue area:UI Related to UI/UX. For Frontend Developers. and removed needs-triage label for new issues that we didn't triage yet labels Jan 31, 2024
@pruoff
Copy link
Contributor
pruoff commented Feb 9, 2024 •
edited
Loading

Hi, I would like to work on this as my first issue, if possible.
@cnkumar20 would that be ok with you?

@pruoff
Copy link
Contributor
pruoff commented Feb 12, 2024

So I have implemented extending the search by:

  • "task:" search will load all task_ids for all necessary dags and give results by case-insensitive pattern-matching.
  • the autocompletion works for this as well. Since the same task_id can be present in many dags, I added an italic ' in <dag_id>' following the task_id suggestion.
    Screenshot 2024-02-11 at 14 25 41
  • additionally I thought it nice to extend current interaction by giving the option to actively limit the search scope by writing "dag:" for dag_id search and "owner:" for owner search.
  • we could always display autocomplete suggestions as ": " e.g. "owner: airflow"

What do you think about these extensions? Did I go too far with the changes and keep it to "task:" search only?

@pruoff pruoff mentioned this issue Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Feature: search dags by task id with suggestions pruoff/airflow
3 participants
@cnkumar20 @RNHTTR @pruoff