8000 [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) by JiriOndrusek · Pull Request #946 · apache/zookeeper · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) #946

wants to merge 1 commit into from

Conversation

JiriOndrusek
Copy link

Issue: https://issues.apache.org/jira/browse/ZOOKEEPER-3389

Cherry-picked from 316962a

Added exported-packages which are required for Curator installation in OSGi

eolivelli
eolivelli requested changes May 13, 2019
View reviewed changes
Copy link
Contributor
@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Maven build as well

@nkalmar
Copy link
Contributor
nkalmar commented May 14, 2019 •
edited
Loading

Less of an importance on branch 3.4 to fix it on maven (we do not plan to release with maven on this branch), but I agree, we should definitely fix it on master and 3.5. I'm also looking into a maven fix.

@anmolnar
Copy link
Contributor

retest maven build

@nkalmar
Copy link
Contributor
nkalmar commented May 30, 2019

Can you backport the maven part from master @JiriOndrusek ? I think it should work the same here.

@JiriOndrusek
Copy link
Author

hi, @nkalmar problem with master branch is, that it is not finished: There has to be made a decision how to continue with this problem (#945 (comment)). As soon as the proper way is selected, I could finish master and then backport it here. With the time distance (from the master PR creation) I tend to a solution, with a new module - only for osgi. I've prepared prototype here: https://github.com/JiriOndrusek/zookeeper/commits/zookeeper-osgi-module

@JiriOndrusek
Copy link
Author
JiriOndrusek commented May 30, 2019 •
edited
Loading

@nkalmar would it be possible to merge ant part - this PR (for purposes of 3.4.x) and merge maven part as soon as is master finished? Because maven part of solution does not exist yet, it will not cause any more difference between ant and maven.

@nkalmar
Copy link
Contributor
nkalmar commented Jun 4, 2019 •
edited
Loading

Yes, this is fine for 3.4, no need for a maven fix. I'll restart the builds, as both failed.
@eolivelli , are you fine with merging just the ant fix for 3.4? We will not build 3.4 with maven. If there will be a fix, it can be backported, but this fix would help folks using OSGi.

@nkalmar
Copy link
Contributor
nkalmar commented Jun 4, 2019

retest this please

@nkalmar
Copy link
Contributor
nkalmar commented Jun 26, 2019

@eolivelli , what do you say we merge this to 3.4 only? Maven will not pass on 3.4 anyway, and this would fix OSGi for the branch. And I don't even think we need a maven fix for 3.4

nkalmar
nkalmar approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor
@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my side, ant fix is enough for 3.4 in my opinion.

eolivelli
eolivelli approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor
@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes
for 3.4 it is enough

asfgit pushed a commit that referenced this pull request Jun 26, 2019
@JiriOndrusek @nkalmar
ZOOKEEPER-3389: Zookeeper does not export all required packages in OS…
4a5d596 
…Gi (for Curator)

Issue: https://issues.apache.org/jira/browse/ZOOKEEPER-3389

Cherry-picked from 316962a

Added exported-packages which are required for Curator installation in OSGi

Author: JiriOndrusek <jondruse@redhat.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes #946 from JiriOndrusek/ZOOKEEPER-3389_export-packages-osgi
@nkalmar
Copy link
Contributor
nkalmar commented Jun 26, 2019

Merged to 3.4, for master and 3.5 see #945
Thanks @JiriOndrusek

@nkalmar nkalmar closed this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkalmar nkalmar nkalmar approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JiriOndrusek @nkalmar @anmolnar @eolivelli
0