fix: making a copy list of componentsBuffer #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rent and Return callback raises InvalidOperationException when a pooled object triggers a new rent or return operation within the callback, causing the componentsBuffer to be altered while it is still being enumerated.
Forgot to add a bracket (I was editing on GitHub website)
|
Allocating a new List for every Invoke will result in poor performance. We can use ArrayPool and Span to avoid this. |
|
You can use CollectionsMarshal to extract the internal array of List as a Span, which eliminates the need to enumerate when copying to the buffer, and further speeds up the process, but this is not available in Unity. You can achieve the same functionality by defining a class with the same memory layout as List, extracting the internal array by performing type conversion with UnsafeUtility.As, and creating a Span. (A similar implementation is available in Cysharp/MemoryPack.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rent and Return callback raises InvalidOperationException when a pooled object triggers a new rent or return operation within the callback, causing the componentsBuffer to be altered while it is still being enumerated.