Description
Use case description
After integrating your DefaultMediaNotificationProvider with the MediaSessionService, I found that there are a few points worth to be discussed, but before jumping into them, I'd like to make sure that I understand the purpose of this class correctly.
Our use case is quite straightforward, displaying media notification for audio playback with custom actions, and the notification building/ bitmap handling in DefaultMediaNotificationProvider is exactly what I need, so I chose to extend this class, provide own BitmapLoader implementation, and override the member functions to achieve the custom actions rather than providing full-blown implementation from scratch.
Everything is working fine, but here are a few things that our team and I think would be nice to improve:
- The
Defaultnaming prefix of the class made me think that we should provide our own implementation originally, but turns out it's quite flexible and we can just extend from it. Maybe a better naming is possible here? - Notification channel id and name are too generic and can't be overridden, we actually would like to provide translations for the channel naming if possible.
- The only way to provide own playback icons is to override by the same resource name, we think that a proper API to override the resources will be a neater solution.
Please let us know your thought about those points, we'll be glad if any of them makes sense to you! Thanks as always.