8000 Insecure increment of numberOfFileWatchers & numberOfFolderWatchers++ · Issue #6 · andreaskoch/go-fswatch · GitHub

More Web Proxy on the site http://driver.im/

Insecure increment of numberOfFileWatchers & numberOfFolderWatchers++ #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

luedigernet opened this issue Nov 14, 2016 · 0 comments

luedigernet commented

Hi the increments should be surrounded with an Mutex to synchronize the write access to the variable. Because of concurrent go routines.

go-fswatch/file.go:
87
88 // increment watcher count
89: numberOfFileWatchers++
90
91 var modTime time.Time

go-fswatch/folder.go:
119
120 // increment watcher count
121: numberOfFolderWatchers++
122
123 for folderWatcher.wasStopped == false {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0