[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(aio): make plunker works with rxjs operators #20124

Merged
merged 1 commit into from
Nov 3, 2017
Merged

build(aio): make plunker works with rxjs operators #20124

merged 1 commit into from
Nov 3, 2017

Conversation

Foxandxss
Copy link
Member

Interestingly it was working on my demos, now it can't find that operators. Luckily, an easy fix.

Also updated TS to 2.4.2 for plunkers.

@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 3, 2017
@mary-poppins
Copy link

You can preview a7a7e3e at https://pr20124-a7a7e3e.ngbuilds.io/.

@gkalpak gkalpak added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 3, 2017
@gkalpak
Copy link
Member
gkalpak commented Nov 3, 2017

Waiting for Travis to pass before marking this for merging.

@sarunint
Copy link
Contributor
sarunint commented Nov 3, 2017

This will break in rxjs@5.5.3 since the file will be gone.

Reference: ReactiveX/rxjs#3025

@mlc-mlapis
Copy link
Contributor

... we are also waiting for ReactiveX/rxjs#3025

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 3, 2017
@petebacondarwin
Copy link
Contributor

@mlc-mlapis Good to know but since this PR locks down the version to 5.5.2, this should not break unexpectedly. We can revisit it once 5.5.3 is released.

@vicb vicb merged commit c7fd172 into angular:master Nov 3, 2017
vicb pushed a commit that referenced this pull request Nov 3, 2017
@Foxandxss @vicb
build(aio): make plunker works with rxjs operators (#20124)
9fa0ffd
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
8 participants
@Foxandxss @mary-poppins @gkalpak @sarunint @mlc-mlapis @petebacondarwin @vicb @googlebot