8000 The example base HREF for a non-custom domain should be terminated with a slash. · Issue #62 · angular-schule/angular-cli-ghpages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

The example base HREF for a non-custom domain should be terminated with a slash. #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000 Closed
TrevorKarjanis opened this issue Aug 6, 2019 · 1 comment
Closed

The example base HREF for a non-custom domain should be terminated with a slash. #62

TrevorKarjanis opened this issue Aug 6, 2019 · 1 comment
Assignees
@JohannesHoppe
Labels
bug low-prio

Comments

@TrevorKarjanis
Copy link

Section A of the documentation for the --base-href option that discusses defining a base HREF for non-custom domains provides the following example.

ng deploy --base-href=/the-repositoryname

This example does not work, because the HREF is not terminated with a slash. Without a slash, the "the-repositoryname" segment is not used. The example may need to be revised.

 ng deploy --base-href=/the-repositoryname/
@JohannesHoppe JohannesHoppe self-assigned this Aug 6, 2019
@JohannesHoppe
Copy link
Member

Thank you for pointing this out! 👍

You are absolutely right, I will create a new version right after this! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohannesHoppe JohannesHoppe

Labels
bug low-prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohannesHoppe @TrevorKarjanis
0