8000 Implement an Angular CLI builder · Issue #59 · angular-schule/angular-cli-ghpages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement an Angular CLI builder #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgechev opened this issue Jul 10, 2019 · 3 comments · Fixed by #60
Closed

Implement an Angular CLI builder #59

mgechev opened this issue Jul 10, 2019 · 3 comments · Fixed by #60

Comments

@mgechev
Copy link
Contributor
mgechev commented Jul 10, 2019

Yesterday I published ngx-gh which does something quite similar. Today @StephenFluin found angular-cli-ghpages and shared it with me.

You're doing a great job! Do you want to work on implementing an Angular CLI builder that will allow invoking the angular-cli-ghpages with ng deploy (once the command gets in the CLI)? I'll be happy to deprecate ngx-gh in favor of angular-cli-ghpages once you have tighter CLI integration.
@JohannesHoppe
Copy link
Member

@mgechev
Thank you so much, that’s a great idea! We already had something like this in mind, but were afraid of the initial effort.

Am I right assuming that it’s okay if we are using existing code from your project?

@JohannesHoppe JohannesHoppe mentioned this issue Aug 5, 2019
Merged
@JohannesHoppe
Copy link
Member

@mgechev I have extended angular-cli-ghpages accordingly. Thank you very much for your advice. 👍 Would you mind taking a quick look to see if everything is okay for you?

@JohannesHoppe JohannesHoppe reopened this Aug 5, 2019
@JohannesHoppe JohannesHoppe mentioned this issue Aug 5, 2019
Closed
@mgechev
Copy link
Contributor Author
mgechev commented Aug 5, 2019

@JohannesHoppe sorry for the delayed response. Everything looks good! Thanks for preserving the commit history! :) Just deprecated ngx-gh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented an Angular CLI builder (ng deploy) angular-schule/angular-cli-ghpages
2 participants
@mgechev @JohannesHoppe
0