8000 `cl` symbols need renaming; `org-element-timestamp-successor` no longer exists · Issue #86 · alphapapa/org-rifle · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cl symbols need renaming; org-element-timestamp-successor no longer exists #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GPPassos opened this issue Sep 4, 2024 · 5 comments
Open

cl symbols need renaming; org-element-timestamp-successor no longer exists #86

GPPassos opened this issue Sep 4, 2024 · 5 comments
Assignees
@alphapapa
Labels
bug help wanted

Comments

@GPPassos
Copy link
GPPassos commented Sep 4, 2024

Thank you a lot for your work, I have been using org-rifle for quite some time now.

After changing my emacs installation, I realised some commands are not working anymore (in particular, due to the usage of second and third, which now are cl-second and cl-third, but also the non-existence of org-element-timestamp-successor).

I also have noticed that this project has not been updated since last year, and that org-ql now has a rifle mode.

So I was wondering: is this project dead? Has it been replaced by rifle mode on org-ql directly?

I am happy to submit a pull request fixing the bugs above I found, but if this project is dead, I wonder if now it might make more sense to tag the repo as deprecated and refer users to org-ql.

Thanks again!
@alphapapa
Copy link
Owner

Org QL supercedes this library in various ways, but org-rifle still works, and users who prefer its UI may still use it. I am not actively developing org-rifle anymore, but I don't object to occasional maintenance on it. There's no need for it to be broken.

You could fix the cl- symbol prefix-related issues by (require 'cl) in your config, or we could fix the symbols in the source code.

org-element-timestamp-successor's disappearance would need fixing. I haven't looked into how it would need to be done.

It probably would be a good idea to mention Org QL at the top of the readme, yes.

@alphapapa alphapapa changed the title Dead project? Issues with cl-macros and org-ql cl symbols need renaming; org-element-timestamp-successor no longer exists Sep 4, 2024
@alphapapa alphapapa self-assigned this Sep 4, 2024
@GPPassos
Copy link
Author
GPPassos commented Sep 6, 2024

Thanks for the quick reply, I might look at it. Indeed I have found that I do prefer using the org-rifle interface but I was unable to change the sorting, which is how I found this bug.

@alphapapa
Copy link
Owner

Indeed I have found that I do prefer using the org-rifle interface but I was unable to change the sorting, which is how I found this bug.

If you're willing, I'd like to talk with you about the interface, because my intent is that Org QL will provide an equivalent or better interface through org-ql-find and related commands, but without depending on Helm's own APIs. That is to say, it should be possible to configure Org QL to provide a nearly equivalent UI to org-rifle. In fact, with regard to the option org-ql-completing-read-snippet-function, it seems that performance in related libraries has improved so that the choice that provides org-rifle-style context works much better now, so I'm considering whether to make it the default choice. If you're interested, I'd be glad to hear your feedback about it. Also, the option org-ql-completing-read-snippet-prefix can be set to a newline, to make the appearance more like that of org-rifle.

@suhail-singh
Copy link

it should be possible to configure Org QL to provide a nearly equivalent UI to
org-rifle

Does UI above include performance characteristics as well?

What would be the recommended way to get helm-org-rifle-org-directory's
refine-as-you-type behavior? When I use org-ql-find-in-org-directory with the
below configuration, I notice that results take longer and don't refresh till
RET is pressed.

(setopt
   org-ql-completing-read-snippet-function #'org-ql-completing-read--snippet-regexp
   org-ql-search-directories-files-recursive nil)

@alphapapa
Copy link
Owner
alphapapa commented May 14, 2025 •
edited
Loading

@suhail-singh It has been difficult to get decent performance from the --snippet-regexp "snippet function" within the Emacs completion API. It seems to work well enough for me now, although it may still feel slower than helm-org-rifle for performing similar searches. However, it may also depend on various factors, such as the completion frontend you're using.

I notice that results take longer and don't refresh till RET is pressed.

It shouldn't be necessary to press RET to make the results update, so that suggests something unusual (or at least, different than mine) in your configuration. Or maybe you found a bug. It's hard to say without a reproducible test case and matching software versions. FWIW, I use Vertico and Orderless (though Orderless shouldn't be relevant to org-ql-find).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphapapa alphapapa

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alphapapa @GPPassos @suhail-singh
0