8000 "Editing a message" via compose buffer becomes "replying to a message" instead · Issue #189 · alphapapa/ement.el · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

"Editing a message" via compose buffer becomes "replying to a message" instead #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phil-s opened this issue Jul 18, 2023 · 6 comments
Closed

"Editing a message" via compose buffer becomes "replying to a message" instead #189

phil-s opened this issue Jul 18, 2023 · 6 comments
Assignees
@alphapapa
Labels
bug Something isn't working
Milestone
0.13

Comments

@phil-s
Copy link
phil-s commented Jul 18, 2023

I'm seeing the following behaviour:

  • Type <insert> to invoke ement-room-edit-message
  • Type C-c ' to invoke ement-room-compose-from-minibuffer

The new compose buffer header line reads:

Press C-x C-s to send message to room (Test) (Replying to message from phil)

And indeed if I send the message it is a new reply to the original message, quoting it and all.

If I do not use C-c ' then editing works as expected.

(I have some customisations in this area, but AFAICS they do not affect this, so hopefully you can reproduce it.)
@phil-s
Copy link
Author
phil-s commented Jul 18, 2023

I guess this is due to ement-room-with-highlighted-event-at causing ement-room-replying-to-event to be set when it's used here:

(defun ement-room-edit-message (event room session body)
  "Edit EVENT in ROOM on SESSION to have new BODY.
The message must be one sent by the local user."
  (interactive (ement-room-with-highlighted-event-at (point)

@alphapapa alphapapa self-assigned this Jul 21, 2023
@alphapapa alphapapa added the bug Something isn't working label Jul 21, 2023
@alphapapa alphapapa added this to the 0.12 milestone Jul 21, 2023
@alphapapa
Copy link
Owner

Thanks for reporting.

@alphapapa alphapapa 8000 modified the milestones: 0.12, 0.13 Sep 14, 2023
@progfolio
Copy link
Contributor

(I have some customisations in this area, but AFAICS they do not affect this, so hopefully you can reproduce it.)

FYI, I am able to reproduce sans customizations.

@alphapapa
Copy link
Owner

That should do it. Please let me know. Thanks.

@progfolio
Copy link
Contributor
progfolio commented Sep 24, 2023 via email

@phil-s
Copy link
Author
phil-s commented Sep 24, 2023 •
edited
Loading

Works for me, thank you!

I'll need to update my custom code at #140 (comment) to support the change, but when I use the standard M-x ement-room-compose-send to apply the edit then it's doing the right thing.

Edit: Done.

@phil-s phil-s mentioned this issue Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphapapa alphapapa

Labels
bug Something isn't working
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
3 participants
@phil-s @alphapapa @progfolio
0