From ab7e7886f8de35c9052d8daef599d751adc80865 Mon Sep 17 00:00:00 2001 From: huangyunbin <395018778@qq.com> Date: Tue, 12 Feb 2019 15:32:54 +0800 Subject: [PATCH] #720 Memory leak in PushService --- .../main/java/com/alibaba/nacos/naming/push/PushService.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/naming/src/main/java/com/alibaba/nacos/naming/push/PushService.java b/naming/src/main/java/com/alibaba/nacos/naming/push/PushService.java index 1f311fb2f75..34826ba6b62 100644 --- a/naming/src/main/java/com/alibaba/nacos/naming/push/PushService.java +++ b/naming/src/main/java/com/alibaba/nacos/naming/push/PushService.java @@ -516,6 +516,7 @@ private static Receiver.AckEntry udpPush(Receiver.AckEntry ackEntry) { if (ackEntry.getRetryTimes() > MAX_RETRY_TIMES) { Loggers.PUSH.warn("max re-push times reached, retry times {}, key: {}", ackEntry.retryTimes, ackEntry.key); ackMap.remove(ackEntry.key); + udpSendTimeMap.remove(ackEntry.key); failedPush += 1; return ackEntry; } @@ -540,6 +541,7 @@ private static Receiver.AckEntry udpPush(Receiver.AckEntry ackEntry) { Loggers.PUSH.error("[NACOS-PUSH] failed to push data: {} to client: {}, error: {}", ackEntry.data, ackEntry.origin.getAddress().getHostAddress(), e); ackMap.remove(ackEntry.key); + udpSendTimeMap.remove(ackEntry.key); failedPush += 1; return null;