8000 修改系统开关entry名和查询系统开关entry名不一致 · Issue #11122 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

修改系统开关entry名和查询系统开关entry名不一致 #11122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HUWEIWEI0105 opened this issue Sep 12, 2023 · 2 comments
Open

修改系统开关entry名和查询系统开关entry名不一致 #11122

HUWEIWEI0105 opened this issue Sep 12, 2023 · 2 comments
Labels
kind/discussion Category issues related to discussion
Milestone
3.0.1

Comments

@HUWEIWEI0105
Copy link

问题：想要关闭health check，查询系统开关entry名字是healthCheckEnabled。但是修改entry名需要写为check，不一致感觉对使用不太友好，要看源码，还有就是debug为false时也不行，只能设置为true。
详细说明：
修改healthCheckEnabled不生效：
image
查看代码发现entry需要指定为check：
image
指定为check后，debug为true时，可以修改成功：
image
debug为false时，修改失败：
image
@KomachiSion
Copy link
Collaborator

这个是从0.X版本就存在的开关，不好修改，只能使用对应定义的开关进行操作。

@KomachiSion
Copy link
Collaborator

需要优化的话， 这里需要双重判断，旧key和新key命中一个即可。

@KomachiSion KomachiSion added the kind/discussion Category issues related to discussion label Sep 14, 2023
@KomachiSion KomachiSion modified the milestones: 2.3.0, 3.0.0 Nov 6, 2023
@KomachiSion KomachiSion modified the milestones: 3.0.0, 3.0.1 Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/discussion Category issues related to discussion
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
2 participants
@HUWEIWEI0105 @KomachiSion
0