8000 Add support to validate signatures from aleph-client · Issue #95 · aleph-im/aleph-client · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support to validate signatures from aleph-client #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hoh opened this issue Aug 18, 2022 · 4 comments
Open

Add support to validate signatures from aleph-client #95

hoh opened this issue Aug 18, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@hoh
Copy link
Member
hoh commented Aug 18, 2022 •
edited
Loading

Aleph-client supports signing messages, but not verifying signatures without the private key.

As a user, I would like to be able to validate the signature of an Aleph message.

See PyAleph: https://github.com/aleph-im/pyaleph/blob/master/src/aleph/chains/ethereum.py#L38
@hoh hoh added the enhancement New feature or request label Aug 18, 2022
@MHHukiewitz
Copy link
Member

What would be the recommended approach for this?

  1. Import aleph from pyaleph
  2. Extract a new module from /chains, create a repo called "aleph-chains" (or similar), and import it into both pyaleph and aleph-client

@odesenfans
Copy link
Contributor

If this is truly needed in aleph-client, I believe it would make sense to move the validators from pyaleph to aleph-message and then use these in aleph-client and pyaleph.

What's the use case though?

@MHHukiewitz
Copy link
Member
MHHukiewitz commented Jan 3, 2023 •
edited
Loading

I want to build an API that uses a simple authentication scheme based on signing the request payload. The user is not directly communicating with the Aleph API, as the intermediary API performs additional checks and sends a different signed message on the user's behalf.

@odesenfans
Copy link
Contributor

Ah so you want to verify all types of signatures, not Aleph messages specifically. Maybe there's value in providing that as another library then and then put the message-specific validation in aleph-message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hoh @odesenfans @MHHukiewitz
0