8000 Make Resolver covered by semver · Issue #953 · algesten/ureq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make Resolver covered by semver #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task
algesten opened this issue Jan 27, 2025 · 2 comments
Open
1 task

Make Resolver covered by semver #953

algesten opened this issue Jan 27, 2025 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@algesten
Copy link
Owner

It currently sits under unversioned to reserve our rights to break compatibility. This issue serves as a place holder for discussion of what needs to happen to move it out from unversioned.

TODO:

  • Get real world usage/feedback of how it is to implement a resolver outside of ureq.
@algesten algesten added the help wanted Extra attention is needed label Jan 27, 2025
@NielDuysters
Copy link

Hi @algesten

In relation to my answer on the similar issue for Transport: #952 (comment)

For my (Arti) Tor library to allow users to use ureq in combination with the Tor network I had to implement a custom Resolver: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2724/diffs#db2862f2c39a5f64834d06757f966cc31edcea1d_0_482

The reason I had to implement a custom resolver is to make sure I was using the Arti-TorClient's own resolver function to resolve the address to avoid DNS-leaks.

Implementing this was extremely straight forward.

I hope my implementation might provide you with some insights.

Also, for Resolver. I am waiting for when this becomes semver and stable.

@algesten
Copy link
Owner Author

Very useful indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@algesten @NielDuysters
0