8000 AMBER: inconsistent use of ```raise Exception``` / ```logger.exception``` · Issue #227 · alchemistry/alchemlyb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
AMBER: inconsistent use of raise Exception / logger.exception #227
Closed
@DrDomenicoMarson

Description

@DrDomenicoMarson

Going through the AMBER parser I noticed that there is inconsistent use of raise Exception (also a little bit broad as an exception), and logger.exception.

I don't know if there is any specific reasoning behind that, but at a first glance, I think it should be advisable to be consistent.

Some possible scenarios:

a) we leave it like that "if it ain't broke, don't fix it" style
b) we unversaly use logger.exception through the code
c) we still use raise some time, but we use more precise Exceptions, maybe creating some more precise Exception-subclasses inside util.py

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0