8000 feat: Add `ja` (Japanese), `yue` (Cantonese), `zh-hans` (Simplified Chinese), and `zh-hant` (Traditional Chinese) by chardoncs · Pull Request #5 · akari-blue/akari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add ja (Japanese), yue (Cantonese), zh-hans (Simplified Chinese), and zh-hant (Traditional Chinese) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

chardoncs
Copy link
Contributor

tho I usually use English, I have some knowledge of those languages.

@chardoncs
Copy link
Contributor Author
chardoncs commented Dec 19, 2024

Currently, there is a minor issue is that locales with region parts (e.g. zh-hans, with hans as the region part) don't work if I pass locales to the language object as below:

export const languages = {
  // -- snip -- //
  "zh-hans": zh_hans,
  "zh-hant": zh_hant,
  // -- snip -- //
};

But zh_hans and zh_hant are fine (but will mess up with the lang attribute):

export const languages = {
  // -- snip -- //
  zh_hans,
  zh_hant,
  // -- snip -- //
};

@ImLunaHey ImLunaHey merged commit 1fa45f6 into akari-blue:main Dec 20, 2024
1 check passed
@ImLunaHey ImLunaHey mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0