8000 fix(gutter): add null check for session.foldWdigets by nlujjawal · Pull Request #5801 · ajaxorg/ace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(gutter): add null check for session.foldWdigets #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

fix(gutter): add null check for session.foldWdigets #5801

merged 1 commit into from
Apr 23, 2025

Conversation

nlujjawal
Copy link
Contributor

Description of changes:
Add null check for session.foldWidgets for the experimental private method $showFoldWidget in gutter layer.

@codecov Codecov
Copy link
codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (e08d4fe) to head (39df5ef).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5801   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         605      605           
  Lines       44620    44620           
  Branches     7301     7301           
=======================================
  Hits        38975    38975           
  Misses       5645     5645
Flag Coverage Δ
unittests 87.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nlujjawal nlujjawal merged commit 6ca40e9 into master Apr 23, 2025
3 checks passed
@nlujjawal nlujjawal deleted the add_session_check branch April 23, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyos xyos xyos approved these changes

@akoreman akoreman akoreman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlujjawal @xyos @akoreman
0