8000 YAML: keys following multiline strings not tokenized as expected · Issue #4694 · ajaxorg/ace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

YAML: keys following multiline strings not tokenized as expected #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevinushey opened this issue May 10, 2022 · 3 comments
Closed

YAML: keys following multiline strings not tokenized as expected #4694

kevinushey opened this issue May 10, 2022 · 3 comments
Assignees
@andrewnester
Labels
bug effort/small good first issue p2 pending-release

Comments

@kevinushey
Copy link
Contributor

Describe the bug

Given the following YAML:

key-1:
    key-2: |
        This is a multi-line string.
    key-3:

The key-3: part is tokenized just as plain text.

Screen Shot 2022-05-10 at 1 28 41 PM

Expected Behavior

The item should be tokenized as a key, as with other keys.

Current Behavior

(see description above)

Reproduction Steps

(see description above)

Possible Solution

I can't quite parse out from the YAML specification as to what's considered "valid" for a key, but I'm guessing that any collection of non-syntactic characters would be valid.

Additional Information/Context

No response

Ace Version

Kitchen sink.
@andrewnester
Copy link
Contributor

it seems like it might have been fixed by this PR already but kitchen sink was not yet updated
#3919

@andrewnester
Copy link
Contributor

NVM, seems to still be reproducible on 1.5.0 and recent kitchen sink

@andrewnester andrewnester self-assigned this May 20, 2022
@andrewnester andrewnester mentioned this issue May 20, 2022
Merged
@andrewnester
Copy link
Contributor

Has been release in 1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewnester andrewnester

Labels
bug effort/small good first issue p2 pending-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinushey @andrewnester
0