This repository was archived by the owner on Jan 15, 2021. It is now read-only.
[Bug] Gas limit estimate too low when two-steps liquidation #1
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
Context :
When liquidating a position using an asset that is not yet unlocked, the UI displays two steps.
Problem :
When performing the steps 1 and 2 consecutively from the same page, the transaction 2 (
liquidationCall) will have a gas estimate that is too low (400000) for the transaction to succeed.I experienced this using Chrome and Metamask.
Here is the failed transaction : https://etherscan.io/tx/0x3a1b7319eeb77c041939e41e401da405ec219b3bc83d160dd82bca9e96e2b7be
Steps to reproduce :
Using Chrome and Metamask...
Go to liquidations page :
https://app.aave.com/liquidations
Choose to liquidate a position for which you haven't yet unlocked the asset.
Unlock the asset (transaction 1) by clicking on "submit" in the "Approve" section and sign it with Metamask.
Once transaction 1 is confirmed, click on submit in the "Liquidation" section. When Metamask opens, click on "EDIT" for the gas fees, then go to "Advanced" tab.
You can see that gas estimate is only
400 000:Workarounds :
Once the transaction 1 is confirmed and the asset is unlocked, instead of proceeding to liquidation directly, first refresh the page (or re-open it in a new tab). You have now a slightly different UI since step 1 has already been completed. This time the gas price estimate will be correct and shouldn't cause the transaction to fail.
Interpretation :
I am pretty sure that is a simple UI problem but I haven't investigated yet.
The text was updated successfully, but these errors were encountered: