Open
Description
Problem:
Functions should only be using {POSIX,RESULT}_BAIL
to return errors from functions. Without these macros, the s2n_errno
variable will not be updated to something sensible and the error becomes more difficult to diagnose.
Solution:
This should be checked in our simple mistakes script. Should be as easy as searching for return S2N_FAILURE
and return S2N_RESULT_ERROR
.