8000 1.112.0 broken with missing Python dependencies · Issue #4832 · aws/jsii · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

1.112.0 broken with missin 8000 g Python dependencies #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
automartin5000 opened this issue May 13, 2025 · 8 comments
Closed
1 task done

1.112.0 broken with missing Python dependencies #4832

automartin5000 opened this issue May 13, 2025 · 8 comments
Labels
bug This issue is a bug. needs-reproduction This issue needs reproduction. p2

Comments

@automartin5000
Copy link
automartin5000 commented May 13, 2025 •
edited
Loading

Describe the bug

I'm not entirely clear how, but #4826 or maybe #4827 appears to have broken JSII for Python installations. It appears to not have any dependencies included.

Here's what the lock file looks like for 1.111.0:
Image

And here's what it looks like for 1.112.0:
Image

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

JSII executes correctly in Python environments.

Current Behavior

ModuleNotFoundError: No module named 'importlib_resources' when executing a JSII app.

Reproduction Steps

Install an app with JSII 1.111.0, no issues. Upgrade to 1.112.0, get above error.

Possible Solution

Revert #4826 and/or #4827

Additional Information/Context

No response

SDK version used

1.112.0

Environment details (OS name and version, etc.)

Mac OS Latest
@automartin5000 automartin5000 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 13, 2025
@github-actions github-actions 8000 bot added the potential-regression Marking this issue as a potential regression to be checked by team member label May 13, 2025
@mrgrain mrgrain added p0 and removed potential-regression Marking this issue as a potential regression to be checked by team member labels May 17, 2025
@mrgrain
Copy link
Contributor
mrgrain commented May 17, 2025

@automartin5000 What file are you looking at here? I can see the corrects deps in the wheel metadata file 🤔

@automartin5000
Copy link
Author
automartin5000 commented May 17, 2025 •
edited
Loading

@mrgrain poetry.lock

@mrgrain
Copy link
Contributor
mrgrain commented May 17, 2025 •
edited
Loading

This seems to still work

$ cdk init app -l python
...
$ source .venv/bin/activate
$ pip install -r requirements.txt
...
$ cdk synth -q
$ pip show jsii 
Name: jsii
Version: 1.112.0

@mrgrain mrgrain added needs-reproduction This issue needs reproduction. and removed p0 needs-triage This issue or PR still needs to be triaged. labels May 17, 2025
@mrgrain
Copy link
Contributor
mrgrain commented May 17, 2025

@automartin5000 I cannot reproduce this:

➜  poetry-demo poetry --version
Poetry (version 1.8.3)
➜  poetry-demo poetry show jsii 
 name         : jsii                           
 version      : 1.112.0                        
 description  : Python client for jsii runtime 

dependencies
 - attrs >=21.2,<26.0
 - cattrs >=1.8,<24.2
 - importlib_resources >=5.2.0
 - publication >=0.0.3
 - python-dateutil *
 - typeguard >=2.13.3,<4.5.0
 - typing_extensions >=3.8,<5.0

poetry.lock also has the correct dependencies. =/

@automartin5000
Copy link
Author

@automartin5000 I cannot reproduce this:

➜  poetry-demo poetry --version
Poetry (version 1.8.3)
➜  poetry-demo poetry show jsii 
 name         : jsii                           
 version      : 1.112.0                        
 description  : Python client for jsii runtime 

dependencies
 - attrs >=21.2,<26.0
 - cattrs >=1.8,<24.2
 - importlib_resources >=5.2.0
 - publication >=0.0.3
 - python-dateutil *
 - typeguard >=2.13.3,<4.5.0
 - typing_extensions >=3.8,<5.0

poetry.lock also has the correct dependencies. =/

Hm, ok, I ran into this after a colleague had this issue. I suppose it could be an issue with our custom project type, though not sure how. Let me see if I can reproduce outside of it.

@mrgrain mrgrain added the p2 label May 19, 2025
@mrgrain
Copy link
Contributor
mrgrain commented May 19, 2025

Marking as a p2 for now. @automartin5000 LMK if you can resolve this on your end or find a reproduction.

@automartin5000
Copy link
Author

Just a quick update: no one else can replicate so I'm thinking it's something machine specific. So I'll close for now.

@github-actions GitHub Actions
Copy link
Contributor

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-reproduction This issue needs reproduction. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrgrain @automartin5000
0