From bab60d3a7e3d14ca20ed8ac8da7d3948083b3271 Mon Sep 17 00:00:00 2001 From: Justin Smith Date: Fri, 9 May 2025 08:44:00 -0400 Subject: [PATCH] Fix usage of clang-tidy-review --- .clang-tidy | 1 - .github/workflows/clang-tidy-review.yml | 5 ++--- util/build_compilation_database.sh | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 834a6b6359..5215833bc1 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -11,6 +11,5 @@ Checks: ' modernize-*, performance-*, portability-*, - readability-* ' WarningsAsErrors: '' diff --git a/.github/workflows/clang-tidy-review.yml b/.github/workflows/clang-tidy-review.yml index 6fb2a7430e..c8e01fdc8a 100644 --- a/.github/workflows/clang-tidy-review.yml +++ b/.github/workflows/clang-tidy-review.yml @@ -9,10 +9,9 @@ jobs: - uses: actions/setup-go@v4 with: go-version: '>=1.18' - - name: Build Project - run: ./util/build_compilation_database.sh - uses: ZedThree/clang-tidy-review@v0.21.0 with: split_workflow: true - + clang_tidy_version: 19 + install_commands: /github/workspace/util/build_compilation_database.sh - uses: ZedThree/clang-tidy-review/upload@v0.21.0 diff --git a/util/build_compilation_database.sh b/util/build_compilation_database.sh index fbab322573..06c27f0b27 100755 --- a/util/build_compilation_database.sh +++ b/util/build_compilation_database.sh @@ -8,7 +8,7 @@ TMP_DIR=`mktemp -d` echo ${TMP_DIR} AWS_LC_BUILD="${TMP_DIR}/AWS-LC-BUILD" -MY_CMAKE_FLAGS=("-GNinja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON") +MY_CMAKE_FLAGS=("-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON" "-DDISABLE_GO=ON") mkdir -p "${AWS_LC_BUILD}"