[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(utils): add additional coverage #4751

Merged
merged 6 commits into from
Jan 12, 2023
Merged

test(utils): add additional coverage #4751

merged 6 commits into from
Jan 12, 2023

Conversation

mind-ar
Copy link
Contributor
@mind-ar mind-ar commented Jan 11, 2023

No description provided.

@authelia
Copy link
authelia bot commented Jan 11, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:test-utils
  • docker pull ghcr.io/authelia/authelia:test-utils

@codecov
Copy link
codecov bot commented Jan 11, 2023 •
edited
Loading

Codecov Report

Merging #4751 (6cc8728) into master (ad1a804) will increase coverage by 0.27%.
The diff coverage is 73.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4751      +/-   ##
==========================================
+ Coverage   67.19%   67.46%   +0.27%     
==========================================
  Files         266      267       +1     
  Lines       19505    19729     +224     
  Branches      429      429              
==========================================
+ Hits        13106    13311     +205     
+ Misses       5639     5638       -1     
- Partials      760      780      +20
Flag Coverage Δ
backend 67.85% <73.93%> (+0.29%) ⬆️
frontend 62.74% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/handlers/handler_sign_totp.go 39.13% <0.00%> (ø)
internal/handlers/handler_sign_webauthn.go 0.00% <0.00%> (ø)
internal/notification/smtp_notifier.go 53.98% <ø> (-0.81%) ⬇️
internal/handlers/handler_firstfactor.go 60.00% <21.05%> (-7.28%) ⬇️
internal/handlers/handler_verify.go 74.27% <50.00%> (-2.53%) ⬇️
internal/utils/strings.go 94.30% <50.00%> (-1.75%) ⬇️
internal/middlewares/authelia_context.go 75.86% <58.49%> (-4.06%) ⬇️
internal/session/session.go 58.82% <58.82%> (ø)
internal/session/provider.go 64.70% <60.86%> (+3.16%) ⬆️
internal/utils/url.go 92.30% <62.50%> (-7.70%) ⬇️
... and 22 more

@mind-ar mind-ar marked this pull request as draft January 11, 2023 22:50
@mind-ar mind-ar marked this pull request as ready for review January 11, 2023 23:00
@netlify
Copy link
netlify bot commented Jan 12, 2023

✅ Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 6cc8728
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/63bfe8dd4bedf6000bc15009
😎 Deploy Preview https://deploy-preview-4751--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

james-d-elliott
james-d-elliott approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member
@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-d-elliott james-d-elliott merged commit 1cf9e6f into master Jan 12, 2023
@james-d-elliott james-d-elliott deleted the test-utils branch January 12, 2023 11:30
mind-ar added a commit that referenced this pull request Jan 15, 2023
@mind-ar
fix(utils): fix suite setup timeout
30cebff 
After PR #4751 the suites times out if takes more of 60 seconds
This PR honors the timeout configured at waitUntilAutheliaBackendIsReady (90s)
@mind-ar mind-ar mentioned this pull request Jan 15, 2023
Merged
james-d-elliott pushed a commit that referenced this pull request Jan 15, 2023
@mind-ar
fix(utils): fix suite setup timeout (#4771)
56f0282 
After PR #4751 the suites times out if takes more of 60 seconds
This PR honors the timeout configured at waitUntilAutheliaBackendIsReady (90s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-d-elliott james-d-elliott james-d-elliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mind-ar @james-d-elliott