10000 Pluralize project API · Issue #3676 · atom/atom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Pluralize project API #3676

Closed
benogle opened this issue Sep 30, 2014 · 2 comments
Closed

Pluralize project API #3676

benogle opened this issue Sep 30, 2014 · 2 comments
Assignees
@nathansobo

Comments

@benogle
Copy link
Contributor
benogle commented Sep 30, 2014

Status: Pull request ready to review/merge.

Via @nathansobo

Here's an initial take:

We want to make it easier to work with files from various locations on disk from within the same Atom window, and the features we have in mind will impact the project API. Conceptually, the two primary changes we want to make are the following:

  • Projects can contain multiple folders.
    • The fuzzy finder should search across all a project's folders.
    • The tree view should display all a project's folders.
  • Workspaces can contain multiple projects.
    • At any one time, there is an "active" project.
    • The fuzzy finder searches across only one active project at a time.
    • The tree view can show multiple projects, with the active project
      emphasized in some way.

The API implications for this seem to be as follows:

  • Multi-folder projects
    • Project::getPath, ::getRepo etc need to be replaced by ::getPaths,
      ::getRepositories, ::getDirectories, etc.
    • The Directory class should probably be expanded to include some of the
      methods on Project.
    • Project::scan and ::replace can continue to work across all directories.
  • Multi-project workspaces
    • Replace atom.project with Workspace::getActiveProject.
    • Add Workspace::getProjects

At first we may just want to add the pluralized APIs for reading, but not add methods to enable multiple directories/projects to actually be added.
@benogle benogle mentioned this issue Sep 30, 2014
Closed
21 tasks
@nathansobo nathansobo changed the title New project API Pluralize project API Oct 1, 2014
@nathansobo
Copy link
Contributor

Decided to only focus on pluralizing the existing project API, which made the work for this quite small. #3691.

@lock
Copy link
lock bot commented Jan 25, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nathansobo nathansobo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nathansobo @benogle
0