Pale Colors #17356
Comments
|
/cc: @jasonrudolph |
|
@schu-r: Thanks for opening this issue. I wasn't familiar with the steps for adding a display profile on Ubuntu, so I've updated the issue body to explain the steps I followed to reproduce this issue. If those steps are incorrect, please let me know. |
|
@jasonrudolph |
|
I captured a few screenshots for reference. All screenshots below are taken using Ubuntu 18.04 with a color profile configured. (See Steps to Reproduce in the issue body.) Using Atom's Default "One Dark" ThemeAtom 1.27.1Atom 1.28.0-beta1Using Atom's "One Light" ThemeAtom 1.27.1Atom 1.28.0-beta1 |
This comment has been minimized.
This comment has been minimized.
|
Over at Atom Discussion (https://discuss.atom.io/t/any-way-to-change-color-rendering-in-atom-1-28-0-beta-electron-2-0-0/55234) @jasonrudolph asked if those of us seeing the issue have color profiles configured. Here is my info: I do have a color profile configured. I generate the color profiles with DisplayCAL and i1Display Pro. The issue appears on both desktop systems I use, Windows 8.1 and Debian Sid (with Gnome v. 3.28, IIRC). Also (which may or may not be relevant), my displays are wide-gamut, that is, they have over 95% AdobeRGB coverage. Cheers! |
|
👋 @schu-r @demetris : I'm still getting up to speed on color profiles, but I think I have a better understanding of the situation now. Would you mind reviewing my findings below? If I'm misunderstanding any of this, please let me know. 🙇 About the different color rendering
As far as I can tell, the Chrome team intentionally updated Chrome's color rendering. In electron/electron#10732 (comment), a member of the Chrome dev team shares this background on the change:
Different, but for a good reason, right?While the Chrome team acknowledges that the color rendering is different now, they contend that the difference is due to the old behavior failing to respect color profiles and the new behavior correctly respecting color profiles. With that in mind, while Atom's color rendering did indeed change in 1.28.0-beta0, this change seems like an improvement, since it now respects a display's color profile. Let's make sure we're seeing the same thing ...The gifs below show the behavior that I'm seeing on Ubuntu 18.04. Does that match the behavior you're seeing? If not, can you please share some gifs or screenshots to so that we can better understand the issue? ExamplesThe examples below compare Chrome's rendering of Sample HTML used for the Chrome demos below<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
<meta charset="utf-8">
<style media="screen">
body {
background-color: #282c34;
}
</style>
</head>
<body>
</body>
</html>Ubuntu 18.04 without custom color profileChrome 66 and Atom 1.28.0-beta1 both render Ubuntu 18.04 with custom color profile (Adobe RGB 1998)When applying the Adobe RGB 1998 color profile, Chrome 66 renders
I think the slight difference between Chrome and Atom might be due to color accuracy refinements that occurred between Chrome 61 (used in Atom 1.28.0-beta1) and Chrome 66 (used in the demo below). |
|
@ryran: Since you observed this change after updating to Atom 1.28, I wanted to share the notes in #17356 (comment) with you in case it helps. I'd love to know if those notes accurately describe the behavior you're seeing. If not, would you mind sharing some gifs or screenshots to so that we can better understand the issue? 🙇 |
|
For those that...
...there is the One Dark Vivid Syntax theme. It's identical, except that the colors are a bit lighter and more saturated.
There are also lots of other One dark based themes with tweaked colors. |
|
|
|
@schu-r What is your monitor's color profile set to? The profile seems to be incorrectly calibrated to an extreme extent. Also, are you seeing equivalent problems with Chrome 66? |
|
Color calibration and color profiles go over my head for the most part, but my feeling is that something is not right in the way Chrome approaches this issue. Why I am saying that? In I want my old colors back! --which I think has been written by a member of the Chrome team-- it says this:
But here is the thing: On my wide-gamut monitors Firefox displays the right parts of the wide-color-gamut photos on the test page just fine (for instance, the WebKit logo in the right part of the first image appears perfectly), and it does that without deviating from the way the rest of the system renders colors. Why is that possible in Firefox but not in Chrome? Maybe there are technical reasons. I would understand that. But if there are no such reasons, maybe it would be possible for Chrome to offer the same options that Firefox does. In Firefox’s 0 -- Color management disabled. (Default in Firefox 3.) In my quick tests measuring the RGB values of solid color blocks, Full color management in Firefox produces the same result as recent versions of Chrome. But it is not the default. If you want full color management, it is there for you to select it: you simply switch the value from 2 to 1. Now, I understand that adding options upon options is not good. I also understand that not everyone needs the same things in a computer monitor. I spend more on monitors than on any other part of my system because I have poor eyesight and my eyes complain easily, not because I am a designer, a photographer or a videographer. I know that, where I see an annoyance, other people may see an improvement. It is just my feeling that in this case, if I understand what Firefox does correctly, we could have our cake and eat it too. Thank you, everyone, for your time! |
👍 Agreed, that looks unusable.
Based on this comment, @schu-r used
I wonder that too, but my guess is that @schu-r set
"most applications"! Could it be that DisplayCAL's calibration is off, but it hasn't been noticed because most applications ignore it? Just now with Chrome and Atom beta it becomes noticeable. I have to add that I never used DisplayCAL, so I don't wanna imply anything. It's just a wild guess. 😇 @schu-r @demetris have you tried to switch the color profile to the default? Just to test how it affects Atom Beta. You might not wanna do that, if your custom profile isn't saved and you can't change back to it. |
Atom 1.28 introduced support for custom ICC color profiles (1) based on the upgrade to Electron 2.x which in turn is based on the latest Chrome version. This version includes changes to the color rendering and now respects the color profile configured in the OS settings. Due to this change for many users the [colors appear to be pale (2). To bring back the previous (more stronger) color rendering Atoms „Core“ → „Color Profile“ must be changed from „Use color profile configured in the operating system“ to „Use sRGB color profile“. References: (1) http://blog.atom.io/2018/06/21/atom-1-28.html#support-for-custom-color-profiles (2) atom/atom#17356 Closes GH-115
|
This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks! |
Uh oh!
There was an error while loading. Please reload this page.
Description
Due a Bug in Chrome If you have a Color Profile all Colors are displayed wrong
From google Forum:
Temporarily for Chrome 61, you can disable color correct rendering by setting chrome://flags/#enable-color-correct-rendering to Disable. Then close and restart Chrome.
Temporarily for Chrome 62, you can set chrome://flags/#force-color-profile to sRGB. Then close and restart Chrome.
Steps to Reproduce
Expected behavior:
Normal Colors
Actual behavior:
All Colors are Pale and Images have complete wrong Colors
Reproduces how often:
100%
Versions
Atom : 1.28.0-beta0
Electron: 2.0.0
Chrome : 61.0.3163.100
Node : 8.9.3
From Ubuntu 18.04 PPA
The text was updated successfully, but these errors were encountered: