8000 sRGB color profile does not work on macOS (1.28.0) · Issue #17564 · atom/atom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

sRGB color profile does not work on macOS (1.28.0) #17564

Closed
1 task done
atomiks opened this issue Jun 23, 2018 · 9 comments
Closed
1 task done

sRGB color profile does not work on macOS (1.28.0) #17564

atomiks opened this issue Jun 23, 2018 · 9 comments
Labels
mac Issues that occur on macOS but not on other platforms. more-information-needed

Comments

@atomiks
Copy link
atomiks commented Jun 23, 2018

Prerequisites

Description

Selecting Use sRGB color profile has no effect on macOS 10.13.4.

Steps to Reproduce

Default

sRGB

OS color profile:

Expected behavior: sRGB should have the same color profile as 1.27.0

Actual behavior: sRGB color profile doesn't work. Using the sRGB OS color profile works, but it enforces the profile everywhere which causes oversaturated imagery. I like it just in my editor for the vibrant syntax colors.

Reproduces how often: 100%

Versions

1.28.0

Additional Information
@thomasjo
Copy link
Contributor

Just double checking since this isn't mentioned in the issue body; did you restart Atom after changing the setting? A prompt/dialog should be triggered by changing the setting, which has a restart button.

The setting is seemingly working for everyone else, so we'll have to figure out why it's not working on your system.

@atomiks
Copy link
Author
atomiks commented Jun 23, 2018 •
edited
Loading

Yes, I tried at least 5 times. I also restarted my computer.

I'll try a fresh install of Atom altogether

Edit: fresh install with no packages, still has no effect
8000

@rsese
Copy link
Contributor
rsese commented Jun 24, 2018

I'll try a fresh install of Atom altogether

Not sure if you only reinstalled Atom, but did you also temporarily reset to factory defaults?

https://flight-manual.atom.io/hacking-atom/sections/debugging/#reset-to-factory-defaults

Then change the setting and restart again?

Also, are there any errors in devtools console?

https://flight-manual.atom.io/hacking-atom/sections/debugging/#check-for-errors-in-the-developer-tools

@atomiks
Copy link
Author
atomiks commented Jun 24, 2018 •
edited
Loading

I deleted the hidden .atom directory before reinstalling, and it seemed to have everything reset completely to default (line-height & font changed, no packages etc). There are no errors in the console.

@jasonrudolph
Copy link
Contributor

Expected behavior: sRGB should have the same color profile as 1.27.0

@atomiks: Can you share a few additional screenshots to help us understand the issue?

  1. Screenshot of the colors you're seeing in Atom 1.27 on macOS 10.13.4
  2. Screenshot of the colors you're seeing in Atom 1.28 on macOS 10.13.4 using Atom's default color profile setting
  3. Screenshot of the colors you're seeing in Atom 1.28 on macOS 10.13.4 using Atom's sRGB color profile setting

As a bonus, if you can use the Digital Color Meter app to show us the exact RGB values in each screenshot (e.g., as seen in #17380 (comment)), that would be extra helpful. 🙏

@jasonrudolph jasonrudolph mentioned this issue Jun 25, 2018
Merged
6 tasks
@winstliu winstliu added the mac Issues that occur on macOS but not on other platforms. label Jun 25, 2018
@atomiks
Copy link
Author
atomiks commented Jun 25, 2018

The colors are the exact same using the sRGB setting and default color profile setting in 1.28.0, as seen in the top two screenshots. I've changed the hex color slightly since, but here are the values:

After pasting the colors in Photoshop.

1.28.0 (with sRGB setting)

The red is: #f07da4
The actual red hex color in the syntax theme: #ff74a5

Photoshop seems to use the sRGB color profile (or maybe Display P3?). I'm using a 2016 MBP which has the wide gamut display so I'm not sure if the colors can actually be seen on other screens via screenshots 🤔 .

1.27.0 vs 1.28.0

@mattpilott
Copy link

I'm seeing this in Mojave with 1.31.0, changing to sRGB has no effect.

@no-response no-response bot closed this as completed Oct 2, 2018
@no-response
Copy link
no-response bot commented Oct 2, 2018

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@rsese rsese mentioned this issue Oct 5, 2018
Closed
@lock
Copy link
lock bot commented Mar 31, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
mac Issues that occur on macOS but not on other platforms. more-information-needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jasonrudolph @thomasjo @rsese @mattpilott @winstliu @atomiks
0