8000 Improve error handling of update-presets-history task · Issue #21 · osmforcities/osmforcities · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve error handling of update-presets-history task #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vgeorge opened this issue Sep 29, 2023 · 0 comments
Open

Improve error handling of update-presets-history task #21

vgeorge opened this issue Sep 29, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@vgeorge
Copy link
Member
vgeorge commented Sep 29, 2023

In the error catch block, the script currently assumes an error means there's no file available for download. This assumption might be misleading, as the error could be due to other reasons, such as a network issue. We should refine the block to consider a 404 status as acceptable (indicating no file available) but throw an error for any other issues.
@vgeorge vgeorge added bug Something isn't working good first issue Good for newcomers labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vgeorge
0