8000 error when passing in a CLI flag that's already in config · Issue #266 · orogene/orogene · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

error when passing in a CLI flag that's already in config #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
8000
zkat opened this issue May 16, 2023 · 1 comment · May be fixed by #300
Open

error when passing in a CLI flag that's already in config #266

zkat opened this issue May 16, 2023 · 1 comment · May be fixed by #300
Assignees
@eryue0220
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zkat
Copy link
Member
zkat commented May 16, 2023 •
edited
Loading

Because of how config stuff works (by passing in "fake" CLI args), if you try to pass a command line flag that's already configured through oro.kdl, it will error telling you there's duplicate flags.

Instead, we should filter the list of flags-from-config such that we don't try to apply the config one if we have a CLI one already.

Repro steps:

  1. Create an oro.kdl file with options { lockfile-only; }, in a basic js project
  2. run cargo run -- apply --lockfile-only
@zkat zkat converted this from a draft issue May 16, 2023
@zkat zkat added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 16, 2023
@zkat zkat moved this to Backlog in Orogene 1.0 Roadmap May 16, 2023
@eryue0220
Copy link
Contributor

I'll try to solve this.

7700
@eryue0220 eryue0220 linked a pull request Oct 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eryue0220 eryue0220

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
Orogene 1.0 Roadmap
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resolve config conflict eryue0220/orogene
2 participants
@zkat @eryue0220
0