Make it clear that "PENDING" comments have to be submitted #10369
Replies: 146 comments 107 replies
-
@medallyon - Any chance you would be willing to share what you learned? How do I properly submit my review so that these comments go away? UPDATE: After much looking, I found the place to "Submit" my review on the "files changed" tab in the upper right hand corner. |
Beta Was this translation helpful? Give feedback.
-
|
wow |
Beta Was this translation helpful? Give feedback.
-
|
Two years later - I just spent the weekend creating but not submitting responses on a PR I wrote. Everyone was wondering, why I had nothing to say. Very frustrating. |
Beta Was this translation helpful? Give feedback.
-
|
I maintain a project for translating game mods. Many users who submit PRs are unfamiliar with GitHub, and some are even unfamiliar with git. There have been many instances where they don't understand the actual meaning of "Pending," and then they ask on Discord, and we have to guide them again. This pending design is so terrible, at least change the wording. |
Beta Was this translation helpful? Give feedback.
-
|
Having the ability to batch up draft comment is rally handy, but the UX around how it's done in GitHub is a disaster. Specific suggestion: When a user has unsent comments EVERY place the PR is show to the user should mention that and clicking on that notification should open the "send your comment now" UI. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you so much - I had no idea you have to go to "files changed" - this is so obscure. |
Beta Was this translation helpful? Give feedback.
-
|
Having to submit my replies to comments on my own PR is very unintuitive in general. But I agree with the original post, it should be more clear that you're in a 'session' that needs to be closed. |
Beta Was this translation helpful? Give feedback.
-
|
just ran into this myself. horrible experience |
Beta Was this translation helpful? Give feedback.
-
|
Same, it was pending for a few days and then the person who submitted the pr said he couldn't see it. Definitely needs more clarity. |
Beta Was this translation helpful? Give feedback.
-
|
This annoys me so hard every single time. And there isn't even a shortcut to submit. CTRL+Return submits it as |
Beta Was this translation helpful? Give feedback.
-
|
Please fix it, I want to reply to other comments without submitting my review yet |
Beta Was this translation helpful? Give feedback.
-
|
Whats problem bro ? |
Be 10000 ta Was this translation helpful? Give feedback.
-
|
@Rashidkhan1234567 No one can see your comment until you submit a review of this thread. |
Beta Was this translation helpful? Give feedback.
-
|
hello |
Beta Was this translation helpful? Give feedback.
-
|
what? |
Beta Was this translation helpful? Give feedback.
-
|
Yeah... this is mega confusing for newer GitHub users. Here's an example where a newer user tells me "But Mike, I've reviewed your PR." And except for the "pending" label, it looks like it! Seriously. "Pending" is a poor choice of words. For so many GitHub users, "pending" sounds like legalese. I'd replace "pending" with something like:
Or maybe with an (i) (info) pop-up that says "To share your comments with the author, select Review changes" (or "Finish your review", depending on the status) |
Beta Was this translation helpful? Give feedback.
-
|
YESSSSS!! So True! The |
Beta Was this translation helpful? Give feedback.
{{editor}}'s edit
-
|
I totally agree, and IMO "Draft" is the right word to use. With a tooltip explaining what it means! |
Beta Was this translation helpful? Give feedback.
-
|
draft would be the PERFECT word to use in this scenario... i don't see why this hasn't been changed yet... |
Beta Was this translation helpful? Give feedback.
-
|
Since @github-staff has yet to respond, I've posted a related Tweet: https://twitter.com/TheMikeJang/status/1562789398034276353?s=20&t=Q9Law9XkEM4WagPewd7AaQ |
Beta Was this translation helpful? Give feedback.
-
|
I've fallen into the same pitfall after a few years not using githuvb reviews 🤦 The Inspiration: the slackbot's |
Beta Was this translation helpful? Give feedback.
-
|
Yes! Please let's do this! The current wording with pending is very misleading, as one can interpret it as "a response from the others is pending". And it's totally not clear, that such pending reviews need to be published. |
Beta Was this translation helpful? Give feedback.
-
|
Voice of reason here! |
Beta Was this translation helpful? Give feedback.
-
|
such a freaking flow. If you just press green button "add review comment" doesn't mean you actually make a comment, you have to submit your comment as well... omg ps should I submit something after pressing "answer" button here? |
Beta Was this translation helpful? Give feedback.
-
|
Ow please yes, change that to be clear in comments. I requested some reviews, but I didn't realize is marked "Pending". 😄 |
Beta Was this translation helpful? Give feedback.
-
|
Happened to me as well, I replied to the reviews and after many days the maintainer made me realize that my comments are PENDING and not even visible to them. Really bad design, Github should definitely make it more intuitive |
Beta Was this translation helpful? Give feedback.
-
|
Yep that just got me too. Here I was wondering why my colleagues hadn't addressed my comments ... because of course they hadn't seen them. Yet another way I dislike Github's PR experience 😡 |
Beta Was this translation helpful? Give feedback.
-
|
I just realized it today after 2 months of being neglected of the reviews... |
Beta Was this translation helpful? Give feedback.
-
|
yes, I meet it |
Beta Was this translation helpful? Give feedback.
-
|
This is just incredible... |
Beta Was this translation helpful? Give feedback.
-
|
The first time it happened to me, my teammate had to message me that he didn't see my comments on his PR. (I was glad I told him I wrote some comments, or I wouldn't have figured it out.) And sometimes my comments would become outdated by the time they are submitted, because the user had already updated the code. |
Beta Was this translation helpful? Give feedback.
-
|
Same happens to me.. |
Beta Was this translation helpful? Give feedback.
-
|
Also I cannot see the button "Submit" in Github mobile app |
Beta Was this translation helpful? Give feedback.
-
|
This is asinine; worst UX I have ever seen in my life. |
Beta Was this translation helpful? Give feedback.
-
|
Bump because this is happening again with some people at work |
Beta Was this translation helpful? Give feedback.
-
|
Still an awful UX. |
Beta Was this translation helpful? Give feedback.
-
|
damn its so stupid, who designed this? no one knows pending=unsubmited |
Beta Was this translation helpful? Give feedback.
-
|
It is a string change that directly impacts UX. How is this taking over 3 years? I don't think anyone from github is actually looking at this. |
Beta Was this translation helpful? Give feedback.
-
|
Post a link to this thread to everything github posts everywhere. This is ridiculous. |
Beta Was this translation helpful? Give feedback.
-
|
Bump |
Beta Was this translation helpful? Give feedback.
-
|
This really sucks, I was waiting for days for someone's reply to my comment only realize my comments never made out of the house. |
Beta Was this translation helpful? Give feedback.
-
|
Bump for the stupidity |
Beta Was this translation helpful? Give feedback.
-
|
This is extremely confusing, since there's no clear way of going from the main tab, to the actual files/review tab if you accidentaly started a review queue, at least a badge on Files changed would help |
Beta Was this translation helpful? Give feedback.
-
|
I did the same mistake more times and it still confuses me. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Not with the current amount of votes it seems |
Beta Was this translation helpful? Give feedback.
-
|
bump. |
Beta Was this translation helpful? Give feedback.
-
|
Happened to me here, we were all a little dumbfounded when we realized this haha. This is a rare UX failure on GitHub's part. I try not to use unduly negative language. But this is very bad design that has probably lost, at minimum, thousands of hours of engineer time. It's an easy UX fail to make, but it's been three years, and it's hard to find a generous interpretation. This seems like a UX fix which would have a good payoff-to-effort ratio. I've not had any of these problems on GitLab or Codeberg. |
Beta Was this translation helpful? Give feedback.
-
|
As someone who has been bit by this more than once over three years, I'm mostly frustrated that this seems to be like a place to report a problem like this - but. clearly no one at Github is paying attention to this forum. I don't recall any acknowledgement yet, that this issue even exists. Another major UX problem, is providing a place for users to post problems, but then NOT paying any attention to that space or the issues posted there. This is a recipe for frustration and disappointment. What are the expectations for this "discussions" space? https://bsky.app/profile/stpaultim.bsky.social/post/3lpagx2dsts2z |
Beta Was this translation helpful? Give feedback.
-
If you load the whole thread, you can see some comments from @queenofcorgis – those short conversations are as close as we got in 3+ years. The current state of affairs is that we can't report this as a bug (gets closed immediately), our only option is that they allow us to be frustrated in this one thread, and they promised that they won't respond. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the pointer. Here is a link to their comments: It's better than nothing, but also not very reassuring. |
Beta Was this translation helpful? Give feedback.
-
|
I know it sounds dramatic for this one little issue, but moving off of GitHub is always another option (i.e. to Codeberg or a selfhosted Forgejo instance, or gitlab, or whatever else) |
Beta Was this translation helpful? Give feedback.
-
|
I've considered it. But, I am part of an opensource project that has over 1000 repositories and 100's of contributors on Github. Moving to another vendor would be a HUGE task (as annoying and problematic as this issue is). I'll be more cautious about starting new projects on Github for sure. |
Beta Was this translation helpful? Give feedback.
-
Ah, that's not the end of it. This is: https://github.com/orgs/community/discussions/10369?sort=top#discussioncomment-8258126 Basically they decided to ignore this thread, because... (drum roll... 🥁) too many people found this bug appalling enough to write here. 🤷♂️ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
It just took me 2 months to figure out that the big, yellow "PENDING" decorator on my comments does NOT mean:
"Your comment is pending to be reviewed by the maintainer."
But it actually means:
"You haven't submitted your comment (along with your review)."
It took me some additional days to figure out how to "submit" the review. I was merely commenting on a review that the maintainer had already started and expected those comments to appear on the reviewer's end as soon as I clicked on "Comment".
See the following:
Beta Was this translation helpful? Give feedback.
All reactions