8000 [Backport] [21] Exception on reading MemoryUsage · Issue #10175 · oracle/graal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [21] Exception on reading MemoryUsage #10175

Closed
gian1200 opened this issue Nov 27, 2024 · 3 comments
Closed

[Backport] [21] Exception on reading MemoryUsage #10175

gian1200 opened this issue Nov 27, 2024 · 3 comments
Assignees
@zakkak
Labels
backport bug community-jdk21u Issues affecting https://github.com/graalvm/graalvm-community-jdk21u

Comments

@gian1200
Copy link

Backport request

Provide a list of links to PRs or commit SHAs you would like to backport.
#6930

List the GraalVM versions you would like to see the changes backported to.
GraalVM for JDK 21 (Community Edition)

Describe the motivation for the backport.
Bug fix on a LTS Java version. Original issue: #6814

Additional context.
@gian1200 gian1200 added the bug label Nov 27, 2024
@zakkak zakkak added backport community-jdk21u Issues affecting https://github.com/graalvm/graalvm-community-jdk21u labels Nov 27, 2024
@zakkak
Copy link
Collaborator
zakkak commented Dec 2, 2024

Hi @roberttoyonaga, could you please provide feedback regarding whether:

  1. Backporting Use -1 as max value for eden and survivor spaces #6930 to GraalVM for JDK 21 would be the right thing to do? Are there other patches we should backport along it?
  2. Backporting Use -1 as max value for eden and survivor spaces #6930 is considered safe?

@roberttoyonaga
Copy link
Collaborator

Hi @zakkak

  1. Use -1 as max value for eden and survivor spaces #6930 can be backported alone. It shouldn't need other patches backported along with it. I think backporting this would be the right thing to do as lacking the patch can cause unexpected exceptions to be thrown (as in Exception on reading MemoryUsage (possible wrong max memory value) #6814). However, if users are erroneously relying on those max memory pool values, backporting this patch will be a breaking change for them (though they really shouldn't be using that data to begin with since max memory pool values don't actually report the true "max").
  2. Aside from the fact that it will affect those relying on the "max" pool sizes, this should be safe. It's very isolated, and I do not believe any machinery internal to SubstrateVM relies on the "max" pool sizes exposed by the memory pool MXBeans, its only for external monitoring.

@zakkak zakkak mentioned this issue Dec 12, 2024
Closed
@zakkak
Copy link
Collaborator
zakkak commented Dec 12, 2024

Moved to graalvm/graalvm-community-jdk21u#30

@zakkak zakkak closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zakkak zakkak

Labels
backport bug community-jdk21u Issues affecting https://github.com/graalvm/graalvm-community-jdk21u
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gian1200 @zakkak @roberttoyonaga
0