Fix link in GFIs to point to no-assignee issues #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lkbhitesh07 PTAL? Thanks! |
Ash-2k3
reviewed
Nov 19, 2024
| @@ -76,7 +76,7 @@ We also **strongly recommend** looking through the resources under "Developing O | |||
|
|
|||
| Welcome! Please make sure to follow the instructions above if you haven't already. | |||
|
|
|||
| After that, you can choose a good first issue from the [list of good first issues](https://github.com/oppia/oppia/labels/good%20first%20issue). These issues are hand-picked to ensure that you don't run into unexpected roadblocks while working on them, and each of them should have clear instructions for new contributors. If you see one that doesn't, please let us know via [GitHub Discussions](https://github.com/oppia/oppia/discussions) and we'll fix it. For other issues, you might need to be more independent because we might not know how to solve them either. | |||
| After that, you can choose a good first issue from the [list of unassigned good first issues](https://github.com/oppia/oppia/issues?q=is%3Aopen+label%3A%22good+first+issue%22+no%3Aassignee). These issues are hand-picked to ensure that you don't run into unexpected roadblocks while working on them, and each of them should have clear instructions for new contributors. If you see one that doesn't, please let us know via [GitHub Discussions](https://github.com/oppia/oppia/discussions) and we'll fix it. For other issues, you might need to be more independent because we might not know how to solve them either. | |||
There was a problem hiding this comment.
Providing the link to unassigned issues is a good idea. However, I had a thought in mind: there are often cases where a new contributor gets assigned to an issue but then disappears. For e.gh: oppia/oppia#20564.
So, I think it's fine to show such issues to them.
Just wanted to check this thought with you!
There was a problem hiding this comment.
Hi @Ash-2k3, that's a great catch, thanks!
I think this is not the place to fix that, though. We already have multiple cases where new contributors try to claim issues that have already been assigned. Instead, we should have some way to check for stale assignments and drop those. I will file an issue to get oppiabot to do that.
Ash-2k3
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the good-first-issues link in the starting instructions to point to issues that have no assignees.