[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing voiceover migration jobs #21348

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Nik-09
Copy link
Member
@Nik-09 Nik-09 commented Nov 27, 2024

Overview

Certain exploration ID ends with a hyphen ('-'), thus we cannot use '-' as a delimiter while extracting exploration ID from snapshot ID. The PR fixes this issue from CreateExplorationVoiceArtistLinkModelsJob.

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Testing doc (for PRs with Beam jobs that modify production server data)

  • A testing doc has been written: ... (ADD LINK) ...
  • (To be confirmed by the server admin) All jobs in this PR have been verified on a live server, and the PR is safe to merge.

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

@Nik-09 Nik-09 requested a review from a team as a code owner November 27, 2024 17:07
@Nik-09 Nik-09 requested a review from lkbhitesh07 November 27, 2024 17:07
Copy link
oppiabot bot commented Nov 27, 2024

Hi @vojtechjelinek, @DubeySandeep, @kevintab95, PTAL at this PR, it modifies files in jobs or platform folders.
Also @Nik-09, please make sure to fill in the server jobs form for the new job or feature to be tested on the backup server. This PR can be merged only after the test run is successful. Please refer to this guide for details.
Thanks!

@oppiabot oppiabot bot added the PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. label Nov 27, 2024
Copy link
oppiabot bot commented Nov 27, 2024

Assigning @lkbhitesh07 for the first pass review of this PR. Thanks!

CURATED_EXPLORATION_ID_2 = 'exploration_id_2'
NON_CURATED_EXPLORATION_ID_3 = 'exploration_id_3'
CURATED_EXPLORATION_ID_1 = 'exp_id_abcde'
CURATED_EXPLORATION_ID_2 = 'exp_id_kjsd-'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added exploration ID with a hyphen at the end to mimic the real exploration ID umPkwp0L1M0-.

Copy link
oppiabot bot commented Dec 6, 2024

Hi @Nik-09, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Dec 6, 2024
@oppiabot oppiabot bot removed the stale label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants