-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing voiceover migration jobs #21348
base: develop
Are you sure you want to change the base?
Conversation
Hi @vojtechjelinek, @DubeySandeep, @kevintab95, PTAL at this PR, it modifies files in jobs or platform folders. |
Assigning @lkbhitesh07 for the first pass review of this PR. Thanks! |
CURATED_EXPLORATION_ID_2 = 'exploration_id_2' | ||
NON_CURATED_EXPLORATION_ID_3 = 'exploration_id_3' | ||
CURATED_EXPLORATION_ID_1 = 'exp_id_abcde' | ||
CURATED_EXPLORATION_ID_2 = 'exp_id_kjsd-' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added exploration ID with a hyphen at the end to mimic the real exploration ID umPkwp0L1M0-.
…ng_voiceover_migration_jobs
Hi @Nik-09, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
…ng_voiceover_migration_jobs
…ng_voiceover_migration_jobs
Overview
Certain exploration ID ends with a hyphen ('-'), thus we cannot use '-' as a delimiter while extracting exploration ID from snapshot ID. The PR fixes this issue from CreateExplorationVoiceArtistLinkModelsJob.
Essential Checklist
Please follow the instructions for making a code change.
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers