8000 Compiler-Options-Hardening-Guide-for-C-and-C++ · Issue #6834 · onnx/onnx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Compiler-Options-Hardening-Guide-for-C-and-C++ #6834

New issue

Have a question about this project? Sign up for 8000 a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andife opened this issue Mar 23, 2025 · 2 comments
Open

Compiler-Options-Hardening-Guide-for-C-and-C++ #6834

andife opened this issue Mar 23, 2025 · 2 comments
Labels
contributions welcome good first issue Good for getting started question Questions about ONNX
Milestone

Comments

@andife
Copy link
Member
andife commented Mar 23, 2025

Ask a Question

Would it make sense to introduce the options proposed there? Which ones would be more problematic for us?
Considering the different operating systems and possible compilers.

https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.html

@cyyever @justinchuby

@andife andife added the question Questions about ONNX label Mar 23, 2025
@cyyever
Copy link
Contributor
cyyever commented Mar 23, 2025

Makes sense for me. The new compile options are relatively easy to add to CMake. And since ONNX is not computation-intensive, the resulting performance penalty is acceptable.

@andife
Copy link
Member Author
andife commented Apr 10, 2025

Speed is certainly interesting in one application or another, so the question for me is a) can we measure this in any reasonable way, b) would it then have to be optional or configurable?

@andife andife added this to the 1.19 milestone Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome good first issue Good for getting started question Questions about ONNX
Projects
None yet
Development

No branches or pull requests

2 participants
0