8000 strict_well 0.5: allOf should have two or more children · Issue #312 · ome/ngff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

strict_well 0.5: allOf should have two or more children #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
toloudis opened this issue May 3, 2025 · 2 comments
Open

strict_well 0.5: allOf should have two or more children #312

toloudis opened this issue May 3, 2025 · 2 comments

Comments

@toloudis
Copy link
toloudis commented May 3, 2025 •
edited
Loading

Currently the 0.5 version of strict_well has an allOf with only a single ref.

ngff/schemas/strict_well.schema

Line 3 in 8cbba21

"allOf": [

This is giving errors when trying to convert with zod as in zod-ome-ngff
It looks like the following might be missing (copying from the 0.4 spec) -- this makes zod-ome-ngff work but I have not yet confirmed that it is 100% correct.

,
    {
      "properties": {
        "well": {
          "required": [
            "version"
          ]
        }
      }
    }
@toloudis toloudis changed the title allOf should have two or more children strict_well 0.5: allOf should have two or more children May 3, 2025
@will-moore
Copy link
Member

As far as I can see, the only difference between strict_well and regular well for v0.4 was the requirement for version, but now that there is no version in v0.5 (because it's moved to the top-level attributes/ome) there is no difference between strict_well and well in v0.5?

@d-v-b
Copy link
Contributor
d-v-b commented May 6, 2025

Currently the 0.5 version of strict_well has an allOf with only a single ref.

ngff/schemas/strict_well.schema

Line 3 in 8cbba21
"allOf": [

This is giving errors when trying to convert with zod as in zod-ome-ngff
It looks like the following might be missing (copying from the 0.4 spec) -- this makes zod-ome-ngff work but I have not yet confirmed that it is 100% correct.

,
    {
      "properties": {
        "well": {
          "required": [
            "version"
          ]
        }
      }
    }

are you generating zod schemas from the ome-zarr JSON schema documents directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@will-moore @toloudis @d-v-b
0