Replace inline styles with tailwind classes #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid browser warnings about inline styles, replace the inline drop shadow style with a very close tailwind class.
Move the inline style to a tailwind class for consistency.
Closed
|
Thanks for these fixes! (Tested locally. I forgot that the secret isn't shared in CI for pull requests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the number of content security policy errors observed in the browser console, replace non-nonced inline styles with their equivalent tailwind classes.
I don't have an oban pro key so I can't run the test suite locally, but in both cases the tailwind style seems like a near-perfect replacement for the original code.