8000 [QA] users' name order is random on suggestion, for same value when sharing with multiple users · Issue #40548 · owncloud/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[QA] users' name order is random on suggestion, for same value when sharing with multiple users #40548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
grgprarup opened this issue Dec 20, 2022 · 2 comments
< 8000 div class="mr-2 mb-2 flex-shrink-0"> Open

[QA] users' name order is random on suggestion, for same value when sharing with multiple users #40548

grgprarup opened this issue Dec 20, 2022 · 2 comments
Labels
discussion Type:Bug

Comments

@grgprarup
Copy link
Contributor

Steps to reproduce

  1. Create user alice, brian, carol
  2. As user alice create a folder/file
  3. Open sharing dialog
  4. Fill the text field in User and Groups with the value brian,carol

Expected behaviour

It would be better if shown in the same order as of input.
briancarol
Note: The issue is only about the preview in the popup. No errors occur when submitting the list. The random behavior gives problems in tests added in PR #40546.

Actual behaviour

The order of the user gets changed when re-input the value or erasing and type again
briancarol
carolbrian
@grgprarup grgprarup changed the title [QA] users' name order is random on suggestion for same value when sharing with multiple users [QA] users' name order is random on suggestion, for same value when sharing with multiple users Dec 20, 2022
@grgprarup grgprarup mentioned this issue Dec 21, 2022
Merged
11 tasks
@phil-davis
Copy link
Contributor

I can't reproduce this manually - I tried all sorts of deleting and typing in different orders, The popup always has the list of usernames in the same order as what I typed.

Anyway, IMO, the UI is not broken if the list of usernames in the popup get displayed in some different order. Users are not going to have any problem choosing the displayed item.

So we should make the tests more flexible. When the test looks for the expected popup item, it can find the text in the popup and then compare in a way that does not depend on the order of usernames in the text.

@grgprarup
Copy link
Contributor Author

I can't reproduce this manually - I tried all sorts of deleting and typing in different orders, The popup always has the list of usernames in the same order as what I typed.

Anyway, IMO, the UI is not broken if the list of usernames in the popup get displayed in some different order. Users are not going to have any problem choosing the displayed item.

So we should make the tests more flexible. When the test looks for the expected popup item, it can find the text in the popup and then compare in a way that does not depend on the order of usernames in the text.

Thank you @phil-davis . I will adjust the test implementation according to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phil-davis @grgprarup
0