8000 Client sessions change dimensions of host terminal. · Issue #138 · owenthereal/upterm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Client sessions change dimensions of host terminal. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Open
m0sth8 opened this issue Oct 31, 2022 · 1 comment
Open

Client sessions change dimensions of host terminal. #138

m0sth8 opened this issue Oct 31, 2022 · 1 comment

Comments

@m0sth8
Copy link
m0sth8 commented Oct 31, 2022

Hi, thank you for the great project.

I noticed that client sessions, including read-only sessions, affect dimensions of host terminal. (https://github.com/owenthereal/upterm/blob/master/host/internal/server.go#L253)
In my case it shouldn't be like that but I wonder if it's something that's expected by other use cases. (e.g. tmux based sessions).
@m0sth8 m0sth8 mentioned this issue Oct 31, 2022
Open
@owenthereal
Copy link
Owner
owenthereal commented Dec 14, 2022 •
edited
Loading

👋 You are correct. The dimensions of the host pty change as a new client joins the session. The current algorithm is that the host pty will be set to the smallest width & smallest height of all clients + the host. This might be problematic to the host if a client with a tiny screen size joins.

What would you expect the host size to be for your use cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owenthereal 2B99 @m0sth8
0