10000 "Back to app" link broken if you logged out from the profile settings page (`/settings`) · Issue #7707 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

"Back to app" link broken if you logged out from the profile settings page (/settings) #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
micolous opened this issue Oct 1, 2024 · 4 comments
Closed

"Back to app" link broken if you logged out from the profile settings page (/settings) #7707

micolous opened this issue Oct 1, 2024 · 4 comments
Labels
bug

Comments

@micolous
Copy link
micolous commented Oct 1, 2024

If you visit /settings while not logged in, it is impossible to go "back to the app" again from any settings page after logging in.

Steps to reproduce

I'm using the Generic OIDC auth provider with OIDC_DISABLE_REDIRECT=true.

  1. While logged into Outline, visit the Profile page (/settings).

  2. Log out of outline. Outline will:

    • terminate the session
    • redirect the browser to / and shows a button to login using the configured identity provider
    • set postLoginRedirectPath = '/settings' in session storage.

  3. Click the button to login using the configured identity provider, approve any consent dialogs.

    Outline should send you to the profile page (/settings) when done (this is expected).

  4. Click Back to App.

Expected behaviour

You are taken back to the Outline app.

Actual behaviour

Outline redirects you to /, then a moment later redirects you back to /settings (Profile page).

Navigating to other settings pages and then clicking "Back to App" also redirects you to the profile page.

Manually navigating to /home also redirects you /settings.

Each time you attempt to leave the settings page, the logger shows:

[lifecycle] Spending post login path 
Object { path: "/settings" }
Logger.ts:26:12

Workaround

Clear the postLoginRedirectPath session storage item.

Versions

Outline (please complete the following information):

  • Install: self hosted Docker
  • Version: 0.80.2

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Firefox 130.0.1, Safari 17.6

Mobile (please complete the following information):
Not tested
@micolous micolous added the bug label Oct 1, 2024
@linear Linear
Copy link
linear bot commented Oct 1, 2024

OLN-682 "Back to app" link broken if you logged out from the profile settings page (`/settings`)

@micolous
Copy link
Author
micolous commented Oct 1, 2024

Actually, this may be a duplicate of #7662

@micolous
Copy link
Author
micolous commented Oct 1, 2024

I added a breakpoint in the same spot ce91071 changed, and manually cleared session storage at that point, and it fixed the issue.

So I'm pretty sure ce91071 will fix this.

@micolous micolous closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@tommoor
Copy link
Member
tommoor commented Oct 1, 2024

Great, I was going to point out that issue too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micolous @tommoor
0