8000 Loom embed broken in HTML downloads · Issue #6245 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Loom embed broken in HTML downloads #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
walski opened this issue Dec 4, 2023 · 0 comments · Fixed by #6290
Closed

Loom embed broken in HTML downloads #6245

walski opened this issue Dec 4, 2023 · 0 comments · Fixed by #6290
Assignees
@tommoor
Labels
bug

Comments

@walski
Copy link
walski commented Dec 4, 2023

To Reproduce

  1. Open a document
  2. Add a Loom embed (/loom)
  3. Use this as an example Loom video url: https://www.loom.com/share/473fad25ebd24b5ea8091503253dfecf
  4. Download document as HTML
  5. Search for loom.com in the downloaded HTML file
  6. See that the embed's iframe src points to https://www.loom.com/share/473fad25ebd24b5ea8091503253dfecf

Expected behavior

The iframe's src should point to https://www.loom.com/embed/473fad25ebd24b5ea8091503253dfecf. Using /share/ instead of /embed/ in the path will prevent the video from being displayed due to X-FRAME-OPTIONS issues with Loom.

The current Outline codebase seems to acknowledge that and explicitly replace share with embed here. But that code might not run when creating the HTML for download?

Happy to help but I'd need a pointer where to look :)

Thank you so much!

Thorben
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommoor tommoor

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Enable embeds within HTML and PDF exports outline/outline
2 participants
@walski @tommoor
0