8000 Deleted Collections is s 404 and shows incorrect User · Issue #6111 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deleted Collections is s 404 and shows incorrect User #6111

New issue
Jump to bottom
Closed
prologic opened this issue Nov 3, 2023 · 5 comments · Fixed by #6116
Closed

Deleted Collections is s 404 and shows incorrect User #6111

prologic opened this issue Nov 3, 2023 · 5 comments · Fixed by #6116
Assignees
@tommoor
Labels
bug

Comments

@prologic
Copy link
prologic commented Nov 3, 2023

Really sorry but I cannot reproduce this as I don't yet fully understand how this happened.

One of our internal users did "something", and one of our collections is just gone / deleted. I assume they accidently deleted the collection, I can't see any other way to reproduce this.

There are two issues I see here:

  1. The reported users is the current user logged in viewing the deleted pages. There doesn't appear to be a way to see "who" actually deleted the collection. This is confusing and misleading.
  2. The "Deleted Collections" link currently 404's so resorting the deleted collection seems to be impossible?
Screenshot 2023-11-04 at 08 10 52 Screenshot 2023-11-04 at 08 11 02
@prologic prologic added the bug label Nov 3, 2023
@prologic
Copy link
Author
prologic commented Nov 3, 2023

The most immediate question I have right now, is:

How do I restore this accidently deleted collection?

More importantly as well, how do we lock collections from accidental mass deletion? 🙏

@tommoor
Copy link
8000 Member
tommoor commented Nov 4, 2023

I think what's happening here is that the last user that updated the document is displayed in the banner. If a document is individually deleted then this will be correct, but if the containing collection is deleted then that "updatedBy" value on each individual document is not updated.

How do I restore this accidently deleted collection?

You can't, the action is permanant – but you can restore each document individually while they still exist in trash or restore from a database backup.

how do we lock collections from accidental mass deletion?

You can ensure that only select users have admin rights in the collection.

@prologic
Copy link
Author
prologic commented Nov 4, 2023

I restored the collection and all documents by poking at the database.

Can we fix the bugs and address improvements I've identified here? Specifically I'd like to see:

  • A way to protect documents and collections
  • A way to undelete collections from the UI which currently 404's
  • The correct use shown in this case, or who deleted the underlying collection.

As an aside a UI for displaying the events table (audit log) would also be super helpful! 🙏

@tommoor tommoor mentioned this issue Nov 5, 2023
Merged
@tommoor tommoor self-assigned this Nov 5, 2023
@tommoor
Copy link
Member
tommoor commented Nov 5, 2023

A way to protect documents and collections

This exists in user roles as mentioned above, you have control over who can delete a collection.

A way to undelete collections from the UI which currently 404's

Existing tracking issue here: #3141

The correct use shown in this case, or who deleted the underlying collection.

Fix here: #6116

A UI for displaying the events table (audit log) would also be super helpful

A detailed audit log is one of the features in the licensed edition.

@prologic
Copy link
Author
prologic commented Nov 5, 2023

Thank you 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommoor tommoor

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Correct user on documents in deleted collection outline/outline
2 participants
@tommoor @prologic
0