8000 Custom themes · Issue #104 · notable/notable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Custom themes #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
drupalshift opened this issue Dec 28, 2018 · 13 comments
Open

Custom themes #104

drupalshift opened this issue Dec 28, 2018 · 13 comments
Labels
enhancement New feature or request
Milestone
Future

Comments

@drupalshift
Copy link

Support for custom colors in editing mode and view ( dark theme, solarized,... )
I always have to adjust my monitor for writing applications that don't support darker themes
Would be nice if you could support this feature
@jletey
Copy link
Contributor
jletey commented Dec 28, 2018

Take a look at #18 ... does this answer your question?

@drupalshift
Copy link
Author

@johnletey That's cool but I mean custom color theme, so you can customize not just dark theme
It would be nice if you can expose some variables so you can customize it, it can get saved like editor config files in Notable directory

@drupalshift
Copy link
Author

Also you can keep settings for custom fonts (#102) in such files

@fabiospampinato
Copy link
Member

There's already a settings file actually (~/.notable.json).

@drupalshift Would support for loading custom css/js files be convenient enough? Or would you prefer some popular themes preloaded to chose from?

@fabiospampinato fabiospampinato added the enhancement New feature or request label Dec 28, 2018
@drupalshift
Copy link
Author
drupalshift commented Dec 29, 2018 •
edited
Loading

@fabiospampinato that's so cool and more than enough, it's more convenient if you can load from repositories which have a certain structure and standard that you have defined for example :

{
     modules : [ 
         "drupalshift/notable-darktheme",
     ]
}

it also more convenient if there was a GUI that you can load/disable/enable these modules and an official modules repository which holds an index to other modules so GUI can list all accepted community modules
I know it's asking for too much, I'm down with loading custom CSS/JS, but just giving you an idea so you can keep in mind for future community-driven development

@fabiospampinato
Copy link
Member

@drupalshift support for full-blown extensions is a bit too far out there yet, but thanks for the suggestion.

@fabiospampinato fabiospampinato changed the title Feature request: Setting for custom theme ( edit / preview ) Custom themes Dec 30, 2018
@shew00
Copy link
shew00 commented Jan 2, 2019

Would support for loading custom css/js files be convenient enough?

I second @drupalshift's request. However, I answer @fabiospampinato's question with a firm yes. Support for loading custom css is convenient enough and would work wonderfully for my use case.

@fbnlsr
Copy link
fbnlsr commented Jan 4, 2019

Loading custom CSS could also help people contribute with themes and let the users not only load their custom CSS but also select from a list of pre-determined themes.

@djordjedjukic
Copy link

Is there a way to get html/css markup from notable?

@fabiospampinato
Copy link
Member

@djordjedjukic what do you mean? You can open the devtools (currently only in dev mode, but devtools will be enabled in the next production release too)

@Arecsu Arecsu mentioned this issue Feb 11, 2019
Open
@fabiospampinato fabiospampinato added this to the Future milestone Feb 22, 2019
@fabiospampinato fabiospampinato mentioned this issue Feb 27, 2019
Open
@fabiospampinato fabiospampinato mentioned this issue May 13, 2019
Closed
@fabiospampinato fabiospampinato mentioned this issue May 20, 2019
Closed
@fabiospampinato fabiospampinato mentioned this issue Jun 18, 2019
Closed
@fabiospampinato
Copy link
Member

Themes as extensions aren't quite here yet, but in v1.9 the built-in themes will be customizable.

@redactedscribe
Copy link
redactedscribe commented Apr 1, 2021 •
edited
Loading

I'd appreciate a dark mode that isn't pure black. With custom themes, I could improve upon the current dark theme, but if Notable could ship with a Light, Dark, and a Night Mode (Night Mode would be the current Dark Mode, and Dark Mode would become a dark gray theme instead), that'd save me a lot of tweaking. Alternatively, just lighten the current Dark Mode (from a UX perspective, pitch black isn't ideal for reading text, at least not when the text is bright white). Check out GitHub's three appearance settings.

@fabiospampinato
Copy link
Member

The current "dark" theme isn't pure black, but I agree that it's too dark, it'll be brighter soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
Future
Development

No branches or pull requests
7 participants
@fabiospampinato @fbnlsr @djordjedjukic @drupalshift @redactedscribe @shew00 @jletey
0